diff --git a/.changeset/clean-news-lay.md b/.changeset/clean-news-lay.md new file mode 100644 index 0000000000..e15546b949 --- /dev/null +++ b/.changeset/clean-news-lay.md @@ -0,0 +1,5 @@ +--- +'@leafygreen-ui/select': major +--- + +Removes support for `refEl` property, which was never leveraged within the component logic. Instead, the `refEl` property always positions the internal MenuButton component against the internal ListBox component. There are no end user changes, just a more precise `SelectProps` type definition. diff --git a/packages/select/src/ListMenu/ListMenu.tsx b/packages/select/src/ListMenu/ListMenu.tsx index fe136de5c9..93ce193e32 100644 --- a/packages/select/src/ListMenu/ListMenu.tsx +++ b/packages/select/src/ListMenu/ListMenu.tsx @@ -4,7 +4,7 @@ import isUndefined from 'lodash/isUndefined'; import { css, cx } from '@leafygreen-ui/emotion'; import { useAvailableSpace } from '@leafygreen-ui/hooks'; import { useDarkMode } from '@leafygreen-ui/leafygreen-provider'; -import Popover, { Align, Justify } from '@leafygreen-ui/popover'; +import { Align, Justify, Popover } from '@leafygreen-ui/popover'; import { DropdownWidthBasis } from '../Select/Select.types'; import SelectContext from '../SelectContext'; diff --git a/packages/select/src/MenuButton/MenuButton.tsx b/packages/select/src/MenuButton/MenuButton.tsx index 67df92ad09..3f2afda545 100644 --- a/packages/select/src/MenuButton/MenuButton.tsx +++ b/packages/select/src/MenuButton/MenuButton.tsx @@ -1,6 +1,6 @@ import React, { useCallback, useContext } from 'react'; -import Button, { Size as ButtonSize, Variant } from '@leafygreen-ui/button'; +import { Button, Size as ButtonSize, Variant } from '@leafygreen-ui/button'; import { css, cx } from '@leafygreen-ui/emotion'; import CaretDownIcon from '@leafygreen-ui/icon/dist/CaretDown'; import { useDarkMode } from '@leafygreen-ui/leafygreen-provider'; diff --git a/packages/select/src/Select/Select.types.ts b/packages/select/src/Select/Select.types.ts index cad7972f5a..5819284811 100644 --- a/packages/select/src/Select/Select.types.ts +++ b/packages/select/src/Select/Select.types.ts @@ -29,7 +29,10 @@ export type DropdownWidthBasis = export interface BaseSelectProps extends Omit, 'onChange' | 'onClick'>, - Omit, + Omit< + PopoverProps, + 'active' | 'dismissMode' | 'onToggle' | 'spacing' | 'refEl' + >, DarkModeProps, LgIdProps { /**