Fix the bug in the helm template for operator envs vars when they are numeric (#552)

# Summary

We had a bug in our helm templating function when we set the env vars
`INIT_DATABASE_VERSION`, `DATABASE_VERSION`, `INIT_OPS_MANAGER_VERSION`,
and `INIT_APPDB_VERSION` using the helm values that are passed for the
helm fields `.Values.initDatabase.version`, `.Values.database.version`,
`.Values.initOpsManager.version` and `.Values.initAppDb.version`
respectively.

Below is the snippet from our `oprator.yaml`.
```
{{- $initDatabaseVersion := print .Values.initDatabase.version (.Values.build | default "") -}}
      env:
            - name: INIT_DATABASE_VERSION
              value: {{ $initDatabaseVersion }}
```

If the values are alphanumeric (`1.2.3`, `jlk345`, `lkjsdf`) that value
is set to the env var properly and the deployment manifest is rendered
successfully, but it fails when we pass plain numeric values for the
helm field `initDatabase.version`. And fails because value of env var in
deployment manifest is expected to be string.

The way operator is installed in our E2E tests is we build the images
first using the master commit sha (**starting 8 chars**) as tag and then
pass that tag as values for above mentioned helm fields. Now if the
commit sha that is generated is alpha numeric, everything works as
expected, but if a commit sha doesn't have any alphabets and just has
numbers the rendering for operator deployment fails.
We got two commits
([1](0089223),
[2](0617759))
in master that just had numbers (**starting 8 charts**) and we passed
those numbers to operator to set as env var, the `helm install` failed.
This PR fixes that by making sure that we always quote the passed
versions to make them string.

## Proof of Work

Unit test to make sure the values are quoted. And manual tests. Also CI
runs in this PR.

Newly added `Environment Variable Quoting Check` helm test passes:
```
[2025/10/27 12:49:24.664] ### Chart [ mongodb-kubernetes ] helm_chart
[2025/10/27 12:49:24.673]  PASS  Environment Variable Quoting Check	helm_chart/tests/operator_env_vars_type_test.yaml
[2025/10/27 12:49:24.715]  PASS  test operator security context settings for values.yaml	helm_chart/tests/operator_security_context_test.yaml
[2025/10/27 12:49:24.717]  PASS  test webhook consistent clusterrole and binding	helm_chart/tests/webhook_clusterrole_test.yaml
[2025/10/27 12:49:24.717] Charts:      1 passed, 1 total
[2025/10/27 12:49:24.717] Test Suites: 3 passed, 3 total
[2025/10/27 12:49:24.717] Tests:       13 passed, 13 total
[2025/10/27 12:49:24.717] Snapshot:    0 passed, 0 total
[2025/10/27 12:49:24.717] Time:        56.760126ms
```

## Checklist

- [x] Have you linked a jira ticket and/or is the ticket in the title?
- [x] Have you checked whether your jira ticket required DOCSP changes?
- [x] Have you added changelog file?
    - use `skip-changelog` label if not needed
- refer to [Changelog files and Release
Notes](https://github.com/mongodb/mongodb-kubernetes/blob/master/CONTRIBUTING.md#changelog-files-and-release-notes)
section in CONTRIBUTING.md for more details

---------

Co-authored-by: Maciej Karaś <[email protected]>

Author: viveksinghggits

config/manager/manager.yaml

@@ -69,21 +69,21 @@ spec:
             - name: INIT_DATABASE_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-database
             - name: INIT_DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # Ops Manager
             - name: OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-enterprise-ops-manager-ubi
             - name: INIT_OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-ops-manager
             - name: INIT_OPS_MANAGER_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # AppDB
             - name: INIT_APPDB_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-appdb
             - name: INIT_APPDB_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: OPS_MANAGER_IMAGE_PULL_POLICY
               value: Always
             - name: AGENT_IMAGE
@@ -208,7 +208,7 @@ spec:
               value: "quay.io/mongodb/mongodb-enterprise-ops-manager-ubi:8.0.14"
             - name: RELATED_IMAGE_OPS_MANAGER_IMAGE_REPOSITORY_8_0_15
               value: "quay.io/mongodb/mongodb-enterprise-ops-manager-ubi:8.0.15"
-      # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
+            # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
             - name: RELATED_IMAGE_MONGODB_IMAGE_4_4_0_ubi8
               value: "quay.io/mongodb/mongodb-enterprise-server:4.4.0-ubi8"
             - name: RELATED_IMAGE_MONGODB_IMAGE_4_4_1_ubi8

helm_chart/templates/operator.yaml

@@ -172,21 +172,21 @@ spec:
             - name: {{ $initDatabaseImageRepositoryEnv }}
               value: {{ .Values.registry.initDatabase }}/{{ .Values.initDatabase.name }}
             - name: INIT_DATABASE_VERSION
-              value: {{ $initDatabaseVersion }}
+              value: {{ $initDatabaseVersion | quote }}
             - name: DATABASE_VERSION
-              value: {{ $databaseVersion }}
+              value: {{ $databaseVersion | quote }}
             # Ops Manager
             - name: {{ $opsManagerImageRepositoryEnv }}
               value: {{ .Values.registry.opsManager }}/{{ .Values.opsManager.name }}
             - name: {{ $initOpsManagerImageRepositoryEnv }}
               value: {{ .Values.registry.initOpsManager }}/{{ .Values.initOpsManager.name }}
             - name: INIT_OPS_MANAGER_VERSION
-              value: {{ $initOpsManagerVersion }}
+              value: {{ $initOpsManagerVersion | quote }}
             # AppDB
             - name: {{ $initAppDbImageRepositoryEnv }}
               value: {{ .Values.registry.initAppDb }}/{{ .Values.initAppDb.name }}
             - name: INIT_APPDB_VERSION
-              value: {{ $initAppDbVersion }}
+              value: {{ $initAppDbVersion | quote }}
             - name: OPS_MANAGER_IMAGE_PULL_POLICY
               value: {{ .Values.registry.pullPolicy }}
             - name: {{ $agentImageEnv }}
@@ -260,7 +260,7 @@ spec:
             - name: RELATED_IMAGE_{{ $opsManagerImageRepositoryEnv }}_{{ $version | replace "." "_" | replace "-" "_" }}
               value: "{{ $.Values.registry.opsManager }}/{{ $.Values.opsManager.name }}:{{ $version }}"
       {{- end }}
-      # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
+            # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
       {{- range $version := .Values.relatedImages.mongodb }}
             - name: RELATED_IMAGE_{{ $mongodbImageEnv }}_{{ $version | replace "." "_" | replace "-" "_" }}
               value: "{{ $.Values.mongodb.repo }}/{{ $.Values.mongodb.name }}:{{ $version }}"

helm_chart/tests/operator_env_vars_type_test.yaml

@@ -0,0 +1,58 @@
+suite: Environment Variable Quoting Check
+templates:
+  - operator.yaml
+tests:
+  - it: should correctly quote the value for the env vars for container images
+    set:
+      initDatabase.version: 1234
+      database.version: 12d3f4
+      initOpsManager.version: 1.2.3
+      initAppDb.version: abc
+    asserts:      
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_DATABASE_VERSION
+            value: "1234"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: DATABASE_VERSION
+            value: "12d3f4"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_OPS_MANAGER_VERSION
+            value: "1.2.3"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_APPDB_VERSION
+            value: "abc"
+  - it: should correctly quote the value for the env vars for container images even when they are passed quoted
+    set:
+      initDatabase.version: "1234"
+      database.version: "12d3f4"
+      initOpsManager.version: "1.2.3"
+      initAppDb.version: "abc"
+    asserts:      
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_DATABASE_VERSION
+            value: "1234"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: DATABASE_VERSION
+            value: "12d3f4"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_OPS_MANAGER_VERSION
+            value: "1.2.3"
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: INIT_APPDB_VERSION
+            value: "abc"

public/mongodb-kubernetes-multi-cluster.yaml

@@ -380,21 +380,21 @@ spec:
             - name: INIT_DATABASE_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-database
             - name: INIT_DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # Ops Manager
             - name: OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-enterprise-ops-manager-ubi
             - name: INIT_OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-ops-manager
             - name: INIT_OPS_MANAGER_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # AppDB
             - name: INIT_APPDB_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-appdb
             - name: INIT_APPDB_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: OPS_MANAGER_IMAGE_PULL_POLICY
               value: Always
             - name: AGENT_IMAGE

public/mongodb-kubernetes-openshift.yaml

@@ -375,21 +375,21 @@ spec:
             - name: INIT_DATABASE_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-database
             - name: INIT_DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # Ops Manager
             - name: OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-enterprise-ops-manager-ubi
             - name: INIT_OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-ops-manager
             - name: INIT_OPS_MANAGER_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # AppDB
             - name: INIT_APPDB_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-appdb
             - name: INIT_APPDB_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: OPS_MANAGER_IMAGE_PULL_POLICY
               value: Always
             - name: AGENT_IMAGE
@@ -512,7 +512,7 @@ spec:
               value: "quay.io/mongodb/mongodb-enterprise-ops-manager-ubi:8.0.14"
             - name: RELATED_IMAGE_OPS_MANAGER_IMAGE_REPOSITORY_8_0_15
               value: "quay.io/mongodb/mongodb-enterprise-ops-manager-ubi:8.0.15"
-      # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
+            # since the official server images end with a different suffix we can re-use the same $mongodbImageEnv
             - name: RELATED_IMAGE_MONGODB_IMAGE_4_4_0_ubi8
               value: "quay.io/mongodb/mongodb-enterprise-server:4.4.0-ubi8"
             - name: RELATED_IMAGE_MONGODB_IMAGE_4_4_1_ubi8

public/mongodb-kubernetes.yaml

@@ -376,21 +376,21 @@ spec:
             - name: INIT_DATABASE_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-database
             - name: INIT_DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: DATABASE_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # Ops Manager
             - name: OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-enterprise-ops-manager-ubi
             - name: INIT_OPS_MANAGER_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-ops-manager
             - name: INIT_OPS_MANAGER_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             # AppDB
             - name: INIT_APPDB_IMAGE_REPOSITORY
               value: quay.io/mongodb/mongodb-kubernetes-init-appdb
             - name: INIT_APPDB_VERSION
-              value: 1.5.0
+              value: "1.5.0"
             - name: OPS_MANAGER_IMAGE_PULL_POLICY
               value: Always
             - name: AGENT_IMAGE