getTaskId(): Replace '-' in hostname with '_' (#223)

JafarAbdi · web-flow · commit 8a913d8bf36e · 2020-12-15T20:39:01.000+01:00
diff --git a/core/src/introspection.cpp b/core/src/introspection.cpp
@@ -57,6 +57,8 @@ std::string getTaskId(const TaskPrivate* task) {
 	std::ostringstream oss;
 	char our_hostname[256] = { 0 };
 	gethostname(our_hostname, sizeof(our_hostname) - 1);
+	// Hostname could have `-` as a character but this is an invalid character in ROS so we replace it with `_`
+	std::replace(std::begin(our_hostname), std::end(our_hostname), '-', '_');
 	oss << our_hostname << "_" << getpid() << "_" << reinterpret_cast<std::size_t>(task);
 	return oss.str();
 }

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ std::string getTaskId(const TaskPrivate* task) {`
`57`	`57`	`std::ostringstream oss;`
`58`	`58`	`char our_hostname[256] = { 0 };`
`59`	`59`	`gethostname(our_hostname, sizeof(our_hostname) - 1);`
	`60`	+ // Hostname could have `-` as a character but this is an invalid character in ROS so we replace it with `_`
	`61`	`+ std::replace(std::begin(our_hostname), std::end(our_hostname), '-', '_');`
`60`	`62`	`oss << our_hostname << "_" << getpid() << "_" << reinterpret_cast<std::size_t>(task);`
`61`	`63`	`return oss.str();`
`62`	`64`	`}`