Skip to content

Commit 35c178c

Browse files
authored
Move learn more link in PremissionsCard (#13870)
1 parent 0ad2239 commit 35c178c

File tree

3 files changed

+20
-18
lines changed

3 files changed

+20
-18
lines changed

src/amo/components/PermissionsCard/index.js

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -77,25 +77,9 @@ export class PermissionsCardBase extends React.Component<InternalProps> {
7777
? i18n.gettext('Data collection:')
7878
: i18n.gettext('Required data collection, according to the developer:');
7979

80-
const header = (
81-
<div className="PermissionsCard-header">
82-
{i18n.gettext('Permissions and data')}
83-
<Link
84-
className="PermissionsCard-learn-more"
85-
href="https://support.mozilla.org/kb/permission-request-messages-firefox-extensions"
86-
target="_blank"
87-
externalDark
88-
prependClientApp={false}
89-
prependLang={false}
90-
>
91-
{i18n.gettext('Learn more')}
92-
</Link>
93-
</div>
94-
);
95-
9680
return (
9781
<ShowMoreCard
98-
header={header}
82+
header={i18n.gettext('Permissions and data')}
9983
contentId={version.id}
10084
className="PermissionsCard"
10185
id="AddonDescription-permissions-card"
@@ -143,6 +127,19 @@ export class PermissionsCardBase extends React.Component<InternalProps> {
143127
</ul>
144128
</>
145129
) : null}
130+
131+
<div className="PermissionsCard-footer">
132+
<Link
133+
className="PermissionsCard-learn-more"
134+
href="https://support.mozilla.org/kb/permission-request-messages-firefox-extensions"
135+
target="_blank"
136+
externalDark
137+
prependClientApp={false}
138+
prependLang={false}
139+
>
140+
{i18n.gettext('Learn more')}
141+
</Link>
142+
</div>
146143
</ShowMoreCard>
147144
);
148145
}

src/amo/components/PermissionsCard/styles.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,7 @@
3232
padding-left: 8px;
3333
}
3434
}
35+
36+
.PermissionsCard-footer {
37+
margin: 24px auto 0;
38+
}

src/amo/pages/Addon/styles.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@
4545
padding: 0;
4646
}
4747

48-
* > .Card-contents {
48+
* > .Card-contents,
49+
*.ShowMoreCard--expanded > .Card-contents {
4950
border-radius: 0;
5051
margin: 0;
5152
padding: 0;

0 commit comments

Comments
 (0)