-
Notifications
You must be signed in to change notification settings - Fork 249
Refactor ads-client to integrate context_id component #6958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ads-client to integrate context_id component #6958
Conversation
|
I wanted to reach out because I believe you are the owner (or at least main contributor) for this ContextId component. I notice in the repo, the README says
This ads-client component is also still unused so no need for this to be production ready or anything yet, but I wanted to make sure that it was okay to start integrating with this component or if there are anticipated major changes coming with this ContextId component. Thanks! |
cfe4b1f to
e2d9fb4
Compare
|
Confirmed with @mikeconley the context_id component is good for us to use. All LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Looks all great to me 🚢
42d2532 to
14c332b
Compare
The pull request has been modified, dismissing previous reviews.
| context_id, | ||
| context_id_component: ContextIDComponent::new( | ||
| &context_id, | ||
| 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should eventually figure out how we want to handle time here, but approving as this is something we can look into more later and don't want to block this merge.
The pull request has been modified, dismissing previous reviews.
8e179ae to
8221538
Compare
8221538 to
52c390c
Compare
The pull request has been modified, dismissing previous reviews.
Refactored the ads-client to use the existing
context_idcrate for uuid generation and lifecycle.Since we are changing existing methods, the tests remain largely the same.
Pull Request checklist
[ci full]to the PR title.