From 0b51297df414e920a4829e7ee07163d6aaccb660 Mon Sep 17 00:00:00 2001
From: Arun KP <arun.kp@olacabs.com>
Date: Wed, 20 Mar 2019 15:52:44 +0530
Subject: [PATCH 1/2] Issue: Signup Modal closing upon clicking on the white
 space above the input box Solution: Added Styling and respective classes to
 make it full height for the container

---
 app/main.css           | 11 +++++++++++
 app/ui/modal.js        |  2 +-
 app/ui/signupDialog.js | 12 ++++++++----
 3 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/app/main.css b/app/main.css
index d916ce900..16e4084ba 100644
--- a/app/main.css
+++ b/app/main.css
@@ -169,6 +169,10 @@ footer li:hover {
   flex-shrink: 0;
 }
 
+.firefox-signup-logo {
+  margin-bottom: 130px;
+}
+
 #password-msg::after {
   content: '\200b';
 }
@@ -288,3 +292,10 @@ select {
 .word-break-all {
   word-break: break-all;
 }
+
+@media screen and (max-width: 768px) {
+  .firefox-signup-logo {
+    margin-bottom: 0;
+    margin-top: 90px;
+  }
+}
diff --git a/app/ui/modal.js b/app/ui/modal.js
index d5beb6bed..f62344a7d 100644
--- a/app/ui/modal.js
+++ b/app/ui/modal.js
@@ -9,7 +9,7 @@ module.exports = function(state, emit) {
       <div
         class="h-full w-full max-h-screen absolute pin-t flex items-center justify-center"
       >
-        <div class="w-full" onclick="${e => e.stopPropagation()}">
+        <div class="w-full h-full" onclick="${e => e.stopPropagation()}">
           ${state.modal(state, emit, close)}
         </div>
       </div>
diff --git a/app/ui/signupDialog.js b/app/ui/signupDialog.js
index 769b40a55..4809d82df 100644
--- a/app/ui/signupDialog.js
+++ b/app/ui/signupDialog.js
@@ -12,10 +12,14 @@ module.exports = function(trigger) {
       <send-signup-dialog
         class="flex flex-col lg:flex-row justify-center px-8 md:px-24 w-full h-full"
       >
-        <img
-          src="${assets.get('firefox_logo-only.svg')}"
-          class="h-16 mt-1 mb-4"
-        />
+        <section
+          class="flex flex-col flex-no-shrink self-center firefox-signup-logo"
+        >
+          <img
+            src="${assets.get('firefox_logo-only.svg')}"
+            class="h-16 mt-1 mb-4"
+          />
+        </section>
         <section
           class="flex flex-col flex-no-shrink self-center lg:mx-6 lg:max-w-xs"
         >

From 5b928bdbac7488196dd7dcd64bbb6b0b93e7b575 Mon Sep 17 00:00:00 2001
From: Arun KP <arun.kp@olacabs.com>
Date: Wed, 20 Mar 2019 16:29:59 +0530
Subject: [PATCH 2/2] Adding the media query fix

---
 app/main.css | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/main.css b/app/main.css
index 16e4084ba..53d33916d 100644
--- a/app/main.css
+++ b/app/main.css
@@ -293,7 +293,7 @@ select {
   word-break: break-all;
 }
 
-@media screen and (max-width: 768px) {
+@media screen and (max-width: 991px) {
   .firefox-signup-logo {
     margin-bottom: 0;
     margin-top: 90px;