Skip to content

Commit 56a9760

Browse files
committed
Merge pull request #31 from mpociot/analysis-qo72jZ
Applied fixes from StyleCI
2 parents b8b6557 + cbcad1e commit 56a9760

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

src/Mpociot/ApiDoc/Commands/GenerateDocumentation.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,10 +204,11 @@ private function processDingoRoutes(AbstractGenerator $generator, $allowedRoutes
204204

205205
/**
206206
* @param $route
207+
*
207208
* @return bool
208209
*/
209210
private function isValidRoute($route)
210211
{
211-
return !is_callable($route->getAction()['uses']);
212+
return ! is_callable($route->getAction()['uses']);
212213
}
213214
}

tests/GenerateDocumentationTest.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Mpociot\ApiDoc\ApiDocGeneratorServiceProvider;
88
use Mpociot\ApiDoc\Generators\LaravelGenerator;
99
use Orchestra\Testbench\TestCase;
10-
use Mpociot\ApiDoc\Tests\Fixtures\TestRequest;
1110
use Mpociot\ApiDoc\Tests\Fixtures\TestController;
1211
use Illuminate\Support\Facades\Route as RouteFacade;
1312

@@ -30,6 +29,7 @@ public function setUp()
3029

3130
/**
3231
* @param \Illuminate\Foundation\Application $app
32+
*
3333
* @return array
3434
*/
3535
protected function getPackageProviders($app)
@@ -45,13 +45,13 @@ public function testConsoleCommandNeedsAPrefixOrRoute()
4545

4646
public function testConsoleCommandDoesNotWorkWithClosure()
4747
{
48-
RouteFacade::get('/api/closure', function(){
48+
RouteFacade::get('/api/closure', function () {
4949
return 'foo';
5050
});
5151
RouteFacade::get('/api/test', TestController::class.'@parseMethodDescription');
5252

5353
$output = $this->artisan('api:generate', [
54-
'--routePrefix' => 'api/*'
54+
'--routePrefix' => 'api/*',
5555
]);
5656
$this->assertContains('Skipping route: api/closure - contains closure.', $output);
5757
$this->assertContains('Processed route: api/test', $output);
@@ -60,11 +60,13 @@ public function testConsoleCommandDoesNotWorkWithClosure()
6060
/**
6161
* @param string $command
6262
* @param array $parameters
63+
*
6364
* @return mixed
6465
*/
6566
public function artisan($command, $parameters = [])
6667
{
6768
$this->app[Kernel::class]->call($command, $parameters);
69+
6870
return $this->app[Kernel::class]->output();
6971
}
7072
}

0 commit comments

Comments
 (0)