feat: Headers are case-insensitive now

Author: muratcorlu

README.md

@@ -81,7 +81,7 @@ Methods:
 
 | Method    | Notes |
 |-------------|-------|
-| [get()](https://expressjs.com/en/4x/api.html#req.get) | Works case sensitive |
+| [get()](https://expressjs.com/en/4x/api.html#req.get) | - |
 | [is()](https://expressjs.com/en/4x/api.html#req.is) | Doesn't support `*` wildcard checks(like `text/*`) |
 
 ### Response Object
@@ -90,8 +90,10 @@ Methods:
 
 | Method    | Notes |
 |-------------|-------|
+| [get()](https://expressjs.com/en/4x/api.html#res.get) | - |
 | [set()](https://expressjs.com/en/4x/api.html#res.set) | Only supports `key, value` parameters |
 | [send()](https://expressjs.com/en/4x/api.html#res.send) | Only supports string values |
 | [status()](https://expressjs.com/en/4x/api.html#res.status) | - |
 | [end()](https://expressjs.com/en/4x/api.html#res.end) | - |
 | [json()](https://expressjs.com/en/4x/api.html#res.json) | - |
+| [type()](https://expressjs.com/en/4x/api.html#res.type) | - |

src/lambda-wrapper.js

@@ -4,12 +4,12 @@ const { Request } = require('./request');
 exports.use = (...handlers) => {
   return (event, context, callback) => {
     const request = new Request(event);
-    const response = new Response(callback);
+    const response = new Response(request, callback);
 
     handlers = [].concat(...handlers);
 
     handlers.reduce((chain, handler) => chain.then(
-      () => new Promise((resolve, reject) => handler(request, response, resolve))
+      () => new Promise((resolve) => handler(request, response, resolve))
     ).catch(callback), Promise.resolve());
   }
 }

src/lambda-wrapper.spec.js

@@ -41,7 +41,7 @@ describe('Lambda Wrapper', () => {
       expect(payload).toEqual({
         statusCode: 200,
         headers: {
-          'Content-Type': 'application/json'
+          'content-type': 'application/json'
         },
         body: '{"a":1}'
       });
@@ -81,7 +81,7 @@ describe('Lambda Wrapper', () => {
       expect(payload).toEqual({
         statusCode: 200,
         headers: {
-          'Content-Type': 'application/json'
+          'content-type': 'application/json'
         },
         body: requestObject
       });
@@ -104,7 +104,7 @@ describe('Lambda Wrapper', () => {
       expect(payload).toEqual({
         statusCode: 200,
         headers: {
-          'Content-Type': 'application/json'
+          'content-type': 'application/json'
         },
         body: JSON.stringify({"b":"1"})
       });
@@ -132,9 +132,12 @@ describe('Lambda Wrapper', () => {
       expect(payload).toEqual({
         statusCode: 200,
         headers: {
-          'Content-Type': 'application/json'
+          'content-type': 'application/json'
         },
-        body: JSON.stringify({"b":"1"})
+        body: JSON.stringify({
+          fromFirstEndpoint: '1',
+          fromSecondEndpoint: '1',
+        })
       });
     }
 
@@ -143,11 +146,11 @@ describe('Lambda Wrapper', () => {
 
   it('should handle errors', () => {
     const lambdaHandler = use((req, res, next) => {
-      throw new Error('test');
+      throw Error('test');
     });
 
     const callback = (err, payload) => {
-      expect(err).toThrow(Error);
+      expect(err).toStrictEqual(Error('test'));
     }
 
     lambdaHandler(proxyRequest, {}, callback);

src/request.js

@@ -1,15 +1,16 @@
+/**
+ *
+ */
 class Request {
   constructor(event) {
-    let body = event.body;
-    if (event.headers['Content-Type'] && event.headers['Content-Type'].indexOf('json') > -1) {
-      body = JSON.parse(event.body);
-    }
-
     this.method = event.httpMethod;
     this.query = event.queryStringParameters;
     this.path = event.path;
     this.params = event.pathParameters;
-    this.headers = event.headers;
+    this.headers = Object.keys(event.headers).reduce((headers, key) => {
+      headers[key.toLowerCase()] = event.headers[key];
+      return headers;
+    }, {});
 
     this.body = event.body;
     if (this.is('json')) {
@@ -18,7 +19,7 @@ class Request {
   }
 
   get(key) {
-    return this.headers[key];
+    return this.headers[key.toLowerCase()];
   }
 
   is(mimeType) {

src/request.spec.js

@@ -25,6 +25,13 @@ describe('Request object', () => {
     expect(request.body).toEqual(requestObject);
   });
 
+  it('should read header', () => {
+    const request = new Request(event);
+
+    expect(request.get('Content-Type')).toBe('application/json');
+    expect(request.get('content-type')).toBe('application/json');
+  })
+
   it('check type', () => {
     const request = new Request(event);
     expect(request.is('json')).toBe(true);

src/response.js

@@ -1,5 +1,15 @@
+/**
+ * Response Object
+ */
 class Response {
-  constructor(callback) {
+  /**
+   * Response object constructor
+   *
+   * @param {Request} req Request object for this Response
+   * @param {function} callback AWS Lambda callback function
+   */
+  constructor(req, callback) {
+    this.req = req;
     this.callback = callback;
     this.responseObj = {
       statusCode: 200,
@@ -8,26 +18,76 @@ class Response {
     };
   }
 
-  set(key, value) {
-    this.responseObj.headers[key] = value;
-  }
-  status(status) {
-    this.responseObj.statusCode = status;
+  /**
+   * Ends the response process.
+   */
+  end() {
+    this.callback(null, this.responseObj);
   }
 
-  send(body) {
-    this.responseObj.body = body;
-    this.end();
+  /**
+   * Get response header value for given key
+   *
+   * @param {string} key Header key to get
+   */
+  get(key) {
+    return this.responseObj.headers[key.toLowerCase()];
   }
 
+  /**
+   * Sends a JSON response. This method sends a response (with the correct content-type) that is the parameter converted to a JSON string using JSON.stringify().
+   *
+   * The parameter can be any JSON type, including object, array, string, Boolean, number, or null, and you can also use it to convert other values to JSON.
+   *
+   * ```js
+   * res.json(null)
+   * res.json({ user: 'tobi' })
+   * res.status(500).json({ error: 'message' })
+   * ```
+   * @param {any} body Any type of oject
+   */
   json(body) {
     this.responseObj.body = JSON.stringify(body);
     this.set('Content-Type', 'application/json');
     this.end();
   }
 
-  end() {
-    this.callback(null, this.responseObj);
+  /**
+   * Sends the HTTP response.
+   *
+   * @param {any} body
+   */
+  send(body) {
+    this.responseObj.body = body;
+    this.end();
+  }
+
+  /**
+   * Set response header
+   *
+   * @param {string} key Header key
+   * @param {string} value Header value
+   */
+  set(key, value) {
+    this.responseObj.headers[key.toLowerCase()] = value;
+  }
+
+  /**
+   * Set status code for response
+   *
+   * @param {integer} status Status code. Ex: 200, 201, 400, 404, 500 etc.
+   */
+  status(status) {
+    this.responseObj.statusCode = status;
+  }
+
+  /**
+   * Sets the Content-Type HTTP header
+   *
+   * @param {string} type Mime type will be set as Content-Type response header
+   */
+  type(type) {
+    this.set('Content-Type', type);
   }
 }
 

src/response.spec.js

@@ -1,10 +1,10 @@
 const { Response } = require('./response');
 
 describe('Response object', () => {
-  test('set response status properly', () => {
+  it('set response status properly', () => {
     const cb = jest.fn();
 
-    const response = new Response(cb);
+    const response = new Response(null, cb);
 
     response.status(404);
     response.end();
@@ -16,18 +16,39 @@ describe('Response object', () => {
     });
   });
 
-  test('send body properly', () => {
-    const cb = jest.fn();
+  it('send body properly', () => {
+    const cb = (err, response) => {
+      expect(response.body).toBe('hello');
+    };
 
-    const response = new Response(cb);
+    const response = new Response(null, cb);
 
     response.send('hello');
+  });
 
-    expect(cb).toHaveBeenCalledWith(null, {
-      statusCode: 200,
-      headers: {},
-      body: 'hello'
-    });
+  it('set content-type', () => {
+    const cb = (err, response) => {
+      expect(response.headers).toBe({
+        'content-type': 'text/html'
+      });
+    };
+    const response = new Response(null, cb);
+
+    response.type('text/html');
+
+  });
+
+
+  it('get header', () => {
+    const cb = (err, response) => {};
+
+    const response = new Response(null, cb);
+
+    response.set('X-Header', 'a');
+
+    expect(response.get('X-Header')).toBe('a');
+    // Should work case insensitive
+    expect(response.get('x-Header')).toBe('a');
   });
 });