Skip to content

Switch to open instead of focus on run #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

Switch to open instead of focus on run #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1244559
switch to open instead of focus
anderson4j Nov 6, 2025
d6e330e
add focus to broken test
anderson4j Nov 7, 2025
74c0049
dont run new command if it doesnt exist (->throws)
anderson4j Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/vscode-extension/src/registrationService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,18 @@ export function registerDisposables(): Disposable[] {
const queryDetailsProvider = new Neo4jQueryDetailsProvider();
const queryVisualizationProvider = new Neo4jQueryVisualizationProvider();
const renderBottomPanel = async (statements: string[]) => {
await commands.executeCommand('neo4jQueryDetails.focus');
await commands.executeCommand('neo4jQueryVisualization.focus');
try {
await commands.executeCommand('neo4jQueryDetails.open', {
preserveFocus: true,
});
await commands.executeCommand('neo4jQueryVisualization.open', {
preserveFocus: true,
});
} catch (e) {
/* no-op */
//If a user (or a test framework) has an old version of vscode, <webview>.open won't exist
//A user can still open the webview manually, so we prefer not to remove focus from the editor
}
await queryVisualizationProvider.viewReadyPromise;
await queryDetailsProvider.executeStatements(statements);
};
Expand Down
5 changes: 2 additions & 3 deletions packages/vscode-extension/tests/specs/webviews/params.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ suite('Params panel testing', () => {

before(async () => {
workbench = await browser.getWorkbench();
await workbench.executeCommand(
'Query Results: Focus on Query Details View',
);
await workbench.executeCommand('neo4jQueryDetails.focus');
await workbench.executeCommand('neo4jQueryVisualization.focus');
});

async function escapeModal(count: number) {
Expand Down