illegalargument 2.6

Author: IoannisPanagiotas

algo/src/main/java/org/neo4j/gds/algorithms/runner/AlgorithmRunner.java

@@ -146,7 +146,7 @@ <R> R runAlgorithm(Algorithm<R> algorithm, String algorithmName) {
         } catch (Exception e) {
             log.warn("Computation failed", e);
             algorithm.getProgressTracker().endSubTaskWithFailure();
-            algorithmMetric.failed();
+            algorithmMetric.failed(e);
             throw e;
         }
     }

algo/src/test/java/org/neo4j/gds/algorithms/runner/AlgorithmRunnerTest.java

@@ -27,6 +27,7 @@
 import org.neo4j.gds.metrics.algorithms.AlgorithmMetricsService;
 
 import static org.assertj.core.api.Assertions.assertThatException;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.RETURNS_DEEP_STUBS;
 import static org.mockito.Mockito.mock;
@@ -63,7 +64,7 @@ void shouldRegisterAlgorithmMetricCountForSuccess() {
         verify(algorithmMetricsServiceMock, times(1)).create("TestingMetrics");
         verify(algorithmMetricMock, times(1)).start();
         verify(algorithmMetricMock, times(1)).close();
-        verify(algorithmMetricMock, times(0)).failed();
+        verify(algorithmMetricMock, times(0)).failed(any());
         verifyNoMoreInteractions(
             algorithmMetricsServiceMock,
             algorithmMetricMock
@@ -103,7 +104,7 @@ void shouldRegisterAlgorithmMetricCountForFailure() {
         verify(algorithmMetricsServiceMock, times(1)).create("TestingMetrics");
         verify(algorithmMetricMock, times(1)).start();
         verify(algorithmMetricMock, times(1)).close();
-        verify(algorithmMetricMock, times(1)).failed();
+        verify(algorithmMetricMock, times(1)).failed(any());
         verifyNoMoreInteractions(
             algorithmMetricsServiceMock,
             algorithmMetricMock

applications/algorithms/path-finding/src/main/java/org/neo4j/gds/applications/algorithms/pathfinding/DefaultAlgorithmProcessingTemplate.java

@@ -159,7 +159,7 @@ private <RESULT_FROM_ALGORITHM> RESULT_FROM_ALGORITHM computeWithMetric(
             return algorithmComputation.compute(graph);
         } catch (RuntimeException e) {
             log.warn("computation failed, halting metrics gathering", e);
-            executionMetric.failed();
+            executionMetric.failed(e);
             throw e;
         }
     }

applications/graph-store-catalog/src/main/java/org/neo4j/gds/applications/graphstorecatalog/DefaultCatalogBusinessFacade.java

@@ -23,27 +23,27 @@
 import org.neo4j.gds.api.DatabaseId;
 import org.neo4j.gds.api.GraphName;
 import org.neo4j.gds.api.User;
+import org.neo4j.gds.beta.filter.GraphFilterResult;
 import org.neo4j.gds.core.CypherMapWrapper;
 import org.neo4j.gds.core.loading.CatalogRequest;
 import org.neo4j.gds.core.loading.GraphDropNodePropertiesResult;
 import org.neo4j.gds.core.loading.GraphDropRelationshipResult;
-import org.neo4j.gds.beta.filter.GraphFilterResult;
 import org.neo4j.gds.core.loading.GraphStoreCatalogService;
 import org.neo4j.gds.core.loading.GraphStoreWithConfig;
-import org.neo4j.gds.termination.TerminationFlag;
 import org.neo4j.gds.core.utils.progress.TaskRegistryFactory;
 import org.neo4j.gds.core.utils.warnings.UserLogRegistryFactory;
 import org.neo4j.gds.core.write.NodeLabelExporterBuilder;
 import org.neo4j.gds.core.write.NodePropertyExporterBuilder;
 import org.neo4j.gds.core.write.RelationshipExporterBuilder;
 import org.neo4j.gds.core.write.RelationshipPropertiesExporterBuilder;
-import org.neo4j.gds.legacycypherprojection.GraphProjectCypherResult;
 import org.neo4j.gds.graphsampling.RandomWalkBasedNodesSampler;
 import org.neo4j.gds.graphsampling.config.RandomWalkWithRestartsConfig;
+import org.neo4j.gds.legacycypherprojection.GraphProjectCypherResult;
 import org.neo4j.gds.logging.Log;
 import org.neo4j.gds.metrics.projections.ProjectionMetricsService;
 import org.neo4j.gds.projection.GraphProjectNativeResult;
 import org.neo4j.gds.results.MemoryEstimateResult;
+import org.neo4j.gds.termination.TerminationFlag;
 import org.neo4j.gds.transaction.TransactionContext;
 import org.neo4j.graphdb.GraphDatabaseService;
 
@@ -246,7 +246,7 @@ public GraphProjectNativeResult nativeProject(
                 configuration
             );
         } catch (Exception e) {
-            projectMetric.failed();
+            projectMetric.failed(e);
             throw e;
         }
     }
@@ -319,7 +319,7 @@ public GraphProjectCypherResult cypherProject(
                 configuration
             );
         } catch (Exception e) {
-            projectMetric.failed();
+            projectMetric.failed(e);
             throw e;
         }
     }
@@ -395,7 +395,7 @@ public GraphFilterResult subGraphProject(
                 originGraphConfiguration.graphStore()
             );
         } catch (Exception e) {
-            subGraphMetric.failed();
+            subGraphMetric.failed(e);
             throw e;
         }
     }

cypher-aggregation/src/main/java/org/neo4j/gds/projection/GraphAggregator.java

@@ -203,7 +203,7 @@ public AnyValue result() throws ProcedureException {
             projectionMetric.start();
             result = buildGraph();
         } catch (Exception e) {
-            projectionMetric.failed();
+            projectionMetric.failed(e);
             throw new ProcedureException(
                 Status.Procedure.ProcedureCallFailed,
                 e,

executor/src/main/java/org/neo4j/gds/executor/ProcedureExecutor.java

@@ -27,10 +27,10 @@
 import org.neo4j.gds.api.GraphStore;
 import org.neo4j.gds.config.AlgoBaseConfig;
 import org.neo4j.gds.core.utils.ProgressTimer;
+import org.neo4j.gds.metrics.algorithms.AlgorithmMetricsService;
 import org.neo4j.gds.termination.TerminationFlag;
 import org.neo4j.graphdb.TransactionTerminatedException;
 import org.neo4j.kernel.api.exceptions.Status;
-import org.neo4j.gds.metrics.algorithms.AlgorithmMetricsService;
 
 import java.util.Map;
 import java.util.Optional;
@@ -146,9 +146,9 @@ private ALGO_RESULT executeAlgorithm(
                 ) {
                     algorithmMetric.start();
                     return algo.compute();
-                } catch (Throwable e) {
+                } catch (Exception e) {
                     algo.getProgressTracker().endSubTaskWithFailure();
-                    algorithmMetric.failed();
+                    algorithmMetric.failed(e);
                     throw e;
                 } finally {
                     if (algoSpec.releaseProgressTask()) {

metrics-api/src/main/java/org/neo4j/gds/metrics/ExecutionMetric.java

@@ -29,7 +29,7 @@ protected ExecutionMetric(String operation) {
 
     public abstract void start();
 
-    public abstract void failed();
+    public abstract void failed(Exception e);
 
     @Override
     public abstract void close();

metrics-api/src/main/java/org/neo4j/gds/metrics/PassthroughExecutionMetric.java

@@ -29,7 +29,7 @@ public final class PassthroughExecutionMetric extends ExecutionMetric {
     public void start() {}
 
     @Override
-    public void failed() {}
+    public void failed(Exception e) {}
 
     @Override
     public void close() {}