Fix compat issue

Co-Authored-By: Paul Horn <[email protected]>

Author: jjaderberg

cypher/5.4/storage-engine-adapter/src/main/java17/org/neo4j/gds/compat/_54/InMemoryCommandCreationContextImpl.java

@@ -20,6 +20,8 @@
 package org.neo4j.gds.compat._54;
 
 import org.neo4j.io.pagecache.context.CursorContext;
+import org.neo4j.kernel.KernelVersion;
+import org.neo4j.kernel.KernelVersionProvider;
 import org.neo4j.lock.LockTracer;
 import org.neo4j.lock.ResourceLocker;
 import org.neo4j.storageengine.api.CommandCreationContext;
@@ -86,13 +88,19 @@ public void close() {
 
     @Override
     public void initialize(
+        KernelVersionProvider kernelVersionProvider,
         CursorContext cursorContext,
         StoreCursors storeCursors,
         Supplier<Long> oldestActiveTransactionSequenceNumber,
-        long currentTransactionSequenceNumber,
         ResourceLocker locks,
         Supplier<LockTracer> lockTracer
     ) {
 
     }
+
+    @Override
+    public KernelVersion kernelVersion() {
+        // NOTE: Double-check if this is still correct when you copy this into a new compat layer
+        return KernelVersion.LATEST;
+    }
 }

cypher/5.4/storage-engine-adapter/src/main/java17/org/neo4j/gds/compat/_54/InMemoryMetaDataProviderImpl.java

@@ -21,7 +21,6 @@
 
 import org.neo4j.internal.recordstorage.InMemoryLogVersionRepository;
 import org.neo4j.io.pagecache.context.CursorContext;
-import org.neo4j.kernel.KernelVersion;
 import org.neo4j.storageengine.api.ClosedTransactionMetadata;
 import org.neo4j.storageengine.api.ExternalStoreId;
 import org.neo4j.storageengine.api.MetadataProvider;
@@ -136,10 +135,6 @@ public StoreId getStoreId() {
         return StoreId.UNKNOWN;
     }
 
-    @Override
-    public void setKernelVersion(KernelVersion kernelVersion) {
-    }
-
     @Override
     public void close() throws IOException {
     }
@@ -179,11 +174,6 @@ public long getLastClosedTransactionId() {
         return this.transactionIdStore.getLastClosedTransactionId();
     }
 
-    @Override
-    public KernelVersion kernelVersion() {
-        return KernelVersion.LATEST;
-    }
-
     @Override
     public Optional<UUID> getDatabaseIdUuid(CursorContext cursorTracer) {
         throw new IllegalStateException("Not supported");

cypher/5.4/storage-engine-adapter/src/main/java17/org/neo4j/gds/compat/_54/InMemoryStorageEngineFactory.java

@@ -55,6 +55,7 @@
 import org.neo4j.io.pagecache.context.CursorContext;
 import org.neo4j.io.pagecache.context.CursorContextFactory;
 import org.neo4j.io.pagecache.tracing.PageCacheTracer;
+import org.neo4j.kernel.KernelVersionRepository;
 import org.neo4j.kernel.api.index.IndexProvidersAccess;
 import org.neo4j.kernel.impl.api.index.IndexProviderMap;
 import org.neo4j.kernel.impl.locking.Locks;
@@ -101,6 +102,7 @@
 import java.io.UncheckedIOException;
 import java.nio.file.OpenOption;
 import java.nio.file.Path;
+import java.time.Clock;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.List;
@@ -114,6 +116,16 @@ public class InMemoryStorageEngineFactory implements StorageEngineFactory {
 
     static final String IN_MEMORY_STORAGE_ENGINE_NAME = "in-memory-54";
 
+    // Record storage = 0, Freki = 1
+    // Let's leave some room for future storage engines
+    // This arbitrary seems quite future-proof
+
+    public static final byte ID = 42;
+    @Override
+    public byte id() {
+        return ID;
+    }
+
     @Override
     public boolean storageExists(FileSystemAbstraction fileSystem, DatabaseLayout databaseLayout) {
         return false;
@@ -122,6 +134,7 @@ public boolean storageExists(FileSystemAbstraction fileSystem, DatabaseLayout da
     @Override
     public StorageEngine instantiate(
         FileSystemAbstraction fs,
+        Clock clock,
         DatabaseLayout databaseLayout,
         Config config,
         PageCache pageCache,
@@ -136,6 +149,7 @@ public StorageEngine instantiate(
         InternalLogProvider userLogProvider,
         RecoveryCleanupWorkCollector recoveryCleanupWorkCollector,
         LogTailMetadata logTailMetadata,
+        KernelVersionRepository kernelVersionRepository,
         MemoryTracker memoryTracker,
         CursorContextFactory cursorContextFactory,
         PageCacheTracer pageCacheTracer

cypher/5.4/storage-engine-adapter/src/main/java17/org/neo4j/gds/compat/_54/InMemoryStorageEngineImpl.java

@@ -183,8 +183,11 @@ public void dumpDiagnostics(InternalLog internalLog, DiagnosticsLogger diagnosti
     }
 
     @Override
-    public List<StorageCommand> createUpgradeCommands(KernelVersion kernelVersion) {
-        return null;
+    public List<StorageCommand> createUpgradeCommands(
+        KernelVersion versionToUpgradeFrom,
+        KernelVersion versionToUpgradeTo
+    ) {
+        return List.of();
     }
 
     @Override