Support smaller integer arrays and scalars

and test more conversions

Author: jjaderberg

core/src/main/java/org/neo4j/gds/core/loading/GdsNeo4jValueConverter.java

@@ -91,7 +91,13 @@ private static Array convertArrayValueOrFail(ArrayValue array) {
             return PrimitiveValues.EMPTY_LONG_ARRAY;
         }
         var arrayCopy = array.asObjectCopy();
-        if (arrayCopy instanceof long[]) {
+        if (arrayCopy instanceof byte[]) {
+            return PrimitiveValues.byteArray((byte[]) arrayCopy);
+        } else if (arrayCopy instanceof short[]) {
+            return PrimitiveValues.shortArray((short[]) arrayCopy);
+        } else if (arrayCopy instanceof int[]) {
+            return PrimitiveValues.intArray((int[]) arrayCopy);
+        } else if (arrayCopy instanceof long[]) {
             return PrimitiveValues.longArray((long[]) arrayCopy);
         } else if (arrayCopy instanceof double[]) {
             return PrimitiveValues.doubleArray((double[]) arrayCopy);

core/src/test/java/org/neo4j/gds/core/loading/GdsNeo4jValueConverterTest.java

@@ -20,16 +20,70 @@
 package org.neo4j.gds.core.loading;
 
 import org.junit.jupiter.api.Test;
-
 import org.neo4j.gds.values.primitive.PrimitiveValues;
 import org.neo4j.values.storable.Values;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
 class GdsNeo4jValueConverterTest {
+
     @Test
     void shouldConvertFloatArray() {
         assertThat(GdsNeo4jValueConverter.toValue(Values.of(new float[]{1, -1})))
             .isEqualTo(PrimitiveValues.floatArray(new float[]{1, -1}));
     }
+
+    @Test
+    void shouldConvertDoubleArray() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(new double[]{1, -1})))
+            .isEqualTo(PrimitiveValues.doubleArray(new double[]{1, -1}));
+    }
+    @Test
+    void shouldConvertLongArray() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(new long[]{1, -1})))
+            .isEqualTo(PrimitiveValues.longArray(new long[]{1, -1}));
+    }
+
+    @Test
+    void shouldConvertIntArray() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(new int[]{1, -1})))
+            .isEqualTo(PrimitiveValues.intArray(new int[]{1, -1}));
+    }
+
+    @Test
+    void shouldConvertShortArray() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(new short[]{1, -1})))
+            .isEqualTo(PrimitiveValues.shortArray(new short[]{1, -1}));
+    }
+
+    @Test
+    void shouldConvertByteArray() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(new byte[]{1, -1})))
+            .isEqualTo(PrimitiveValues.byteArray(new byte[]{1, -1}));
+    }
+
+    @Test
+    void shouldConvertFloat() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(1F)))
+            .isEqualTo(PrimitiveValues.floatingPointValue(1F));
+    }
+
+    @Test
+    void shouldConvertDouble() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(1D)))
+            .isEqualTo(PrimitiveValues.floatingPointValue(1D));
+    }
+
+    @Test
+    void shouldConvertInt() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(1)))
+            .isEqualTo(PrimitiveValues.longValue(1));
+    }
+
+    @Test
+    void shouldConvertLong() {
+        assertThat(GdsNeo4jValueConverter.toValue(Values.of(1L)))
+            .isEqualTo(PrimitiveValues.longValue(1L));
+    }
+
 }