Skip to content

Commit c0b371b

Browse files
move testing
1 parent 9931c60 commit c0b371b

File tree

1 file changed

+35
-10
lines changed

1 file changed

+35
-10
lines changed

algo/src/test/java/org/neo4j/gds/pagerank/PageRankConfigTest.java renamed to procedures/facade-api/configs/centrality-configs/src/test/java/org/neo4j/gds/pagerank/PageRankConfigTest.java

Lines changed: 35 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,22 @@
1919
*/
2020
package org.neo4j.gds.pagerank;
2121

22-
import org.junit.jupiter.api.Test;
22+
import org.junit.jupiter.params.ParameterizedTest;
23+
import org.junit.jupiter.params.provider.Arguments;
24+
import org.junit.jupiter.params.provider.MethodSource;
2325
import org.neo4j.gds.api.GraphStore;
2426
import org.neo4j.gds.extension.GdlExtension;
2527
import org.neo4j.gds.extension.GdlGraph;
2628
import org.neo4j.gds.extension.Inject;
2729

2830
import java.util.List;
31+
import java.util.stream.Stream;
2932

3033
import static org.assertj.core.api.Assertions.assertThatThrownBy;
34+
import static org.junit.jupiter.params.provider.Arguments.arguments;
3135

3236
@GdlExtension
33-
public class PageRankConfigTest {
37+
class PageRankConfigTest {
3438

3539
@GdlGraph
3640
private static final String DB_CYPHER =
@@ -39,20 +43,41 @@ public class PageRankConfigTest {
3943
" (b:node)," +
4044
"(a)-[:R]->(b)";
4145

42-
4346
@Inject
4447
private GraphStore graphStore;
4548

46-
@Test
47-
void shouldNotAllowNegativeSourceNodes() {
48-
assertThatThrownBy(() -> PageRankStreamConfigImpl.builder().sourceNodes(List.of(-1337)).build())
49-
.hasMessageContaining("Negative node ids are not supported for the field `sourceNodes`");
49+
static Stream<Arguments> negativeSourceNodes() {
50+
return Stream.of(
51+
arguments(-1337),
52+
arguments(List.of(-1337)),
53+
arguments(List.of(List.of(-1337, 1.0)))
54+
);
55+
}
56+
57+
@ParameterizedTest
58+
@MethodSource("negativeSourceNodes")
59+
void shouldNotAllowNegativeSourceNodes(Object sourceNodes) {
60+
assertThatThrownBy(() -> PageRankStreamConfigImpl
61+
.builder()
62+
.sourceNodes(sourceNodes)
63+
.build()
64+
).hasMessageContaining("Negative node ids are not supported for the field `sourceNodes`");
5065
}
5166

52-
@Test
53-
void shouldNotAllowNonExistantSourceNodes() {
67+
static Stream<Arguments> invalidSourceNodes() {
68+
return Stream.of(
69+
arguments(421337),
70+
arguments(List.of(421337)),
71+
arguments(List.of(List.of(421337, 1.0)))
72+
);
73+
}
74+
75+
76+
@ParameterizedTest
77+
@MethodSource("invalidSourceNodes")
78+
void shouldNotAllowNonExistantSourceNodes(Object sourceNodes) {
5479
var config = PageRankStreamConfigImpl.builder()
55-
.sourceNodes(List.of(421337)).build();
80+
.sourceNodes(sourceNodes).build();
5681

5782
assertThatThrownBy(() -> config.graphStoreValidation(
5883
graphStore,

0 commit comments

Comments
 (0)