Merge pull request #8556 from vnickolov/remove-spotbugs-2.5

Remove SpotBugs

Author: vnickolov

algo-common/build.gradle

@@ -11,7 +11,6 @@ dependencies {
 
     compileOnly group: 'org.jetbrains',     name: 'annotations',        version: ver.'jetbrains-annotations'
     compileOnly group: 'org.immutables',    name: 'value-annotations',  version: ver.'immutables'
-    compileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
     neodeps().each {
         compileOnly(group: 'org.neo4j', name: it, version: ver.'neo4j') {
             transitive = false
@@ -31,7 +30,6 @@ dependencies {
 
     implementation group: 'org.hdrhistogram', name: 'HdrHistogram', version: ver.'HdrHistogram'
 
-    testCompileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
     testImplementation project(':test-utils')
     testImplementation project(':graph-schema-api')
 }

algo-test/build.gradle

@@ -14,8 +14,6 @@ dependencies {
     compileOnly group: 'org.immutables',      name: 'value-annotations',    version: ver.'immutables'
     compileOnly group: 'org.immutables',      name: 'builder',              version: ver.'immutables'
     compileOnly group: 'org.jetbrains',       name: 'annotations',          version: ver.'jetbrains-annotations'
-    compileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
-
 
     neodeps().each {
         compileOnly(group: 'org.neo4j', name: it, version: ver.'neo4j') {

algo/build.gradle

@@ -14,7 +14,6 @@ dependencies {
     compileOnly group: 'org.immutables', name: 'value-annotations', version: ver.'immutables'
     compileOnly group: 'org.immutables', name: 'builder', version: ver.'immutables'
     compileOnly group: 'org.jetbrains', name: 'annotations', version: ver.'jetbrains-annotations'
-    compileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
 
     implementation group: 'org.apache.commons', name: 'commons-math3', version: ver.'commons-math3'
 
@@ -52,8 +51,6 @@ dependencies {
     testAnnotationProcessor project(':annotations')
     testAnnotationProcessor project(':config-generator')
 
-    testCompileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
-
     testImplementation project(':edition-api')
     testImplementation project(':test-utils')
     testImplementation project(':ml-test-utils')

algo/src/main/java/org/neo4j/gds/scaleproperties/ScaleProperties.java

@@ -19,20 +19,20 @@
  */
 package org.neo4j.gds.scaleproperties;
 
+import org.jetbrains.annotations.Nullable;
 import org.neo4j.gds.Algorithm;
 import org.neo4j.gds.annotation.ValueClass;
 import org.neo4j.gds.api.Graph;
 import org.neo4j.gds.api.IdMap;
 import org.neo4j.gds.api.properties.nodes.DoubleNodePropertyValues;
 import org.neo4j.gds.api.properties.nodes.NodePropertyValues;
-import org.neo4j.gds.core.concurrency.RunWithConcurrency;
 import org.neo4j.gds.collections.ha.HugeObjectArray;
+import org.neo4j.gds.core.concurrency.RunWithConcurrency;
 import org.neo4j.gds.core.utils.partition.PartitionUtils;
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
 import org.neo4j.gds.scaling.ScalarScaler;
 import org.neo4j.gds.scaling.Scaler;
 
-import javax.annotation.Nullable;
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;

algo/src/test/java/org/neo4j/gds/embeddings/graphsage/GraphSageModelTrainerTest.java

@@ -19,7 +19,6 @@
  */
 package org.neo4j.gds.embeddings.graphsage;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.assertj.core.data.Offset;
 import org.assertj.core.util.DoubleComparator;
 import org.junit.jupiter.api.BeforeEach;
@@ -34,8 +33,8 @@
 import org.neo4j.gds.beta.generator.PropertyProducer;
 import org.neo4j.gds.beta.generator.RandomGraphGenerator;
 import org.neo4j.gds.beta.generator.RelationshipDistribution;
-import org.neo4j.gds.core.concurrency.DefaultPool;
 import org.neo4j.gds.collections.ha.HugeObjectArray;
+import org.neo4j.gds.core.concurrency.DefaultPool;
 import org.neo4j.gds.core.utils.progress.tasks.ProgressTracker;
 import org.neo4j.gds.embeddings.graphsage.algo.GraphSageTrainConfigImpl;
 import org.neo4j.gds.extension.GdlExtension;
@@ -60,11 +59,9 @@ class GraphSageModelTrainerTest {
     private final int FEATURES_COUNT = 5;
     private final int EMBEDDING_DIMENSION = 64;
 
-    @SuppressFBWarnings("HSC_HUGE_SHARED_STRING_CONSTANT")
     @GdlGraph
     private static final String GDL = GraphSageTestGraph.GDL;
 
-    @SuppressFBWarnings
     @GdlGraph(orientation = Orientation.UNDIRECTED, graphNamePrefix = "array")
     private static final String ARRAY_GRAPH = "CREATE" +
                                               "  (a { features: [-1.0, 2.1] })" +

algo/src/test/java/org/neo4j/gds/embeddings/graphsage/algo/GraphSageTrainAlgorithmFactoryTest.java

@@ -19,7 +19,6 @@
  */
 package org.neo4j.gds.embeddings.graphsage.algo;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.eclipse.collections.api.tuple.primitive.IntObjectPair;
 import org.eclipse.collections.api.tuple.primitive.LongLongPair;
 import org.eclipse.collections.impl.tuple.Tuples;
@@ -74,7 +73,6 @@ class GraphSageTrainAlgorithmFactoryTest {
 
     private static final int SOME_REASONABLE_VALUE = 100;
 
-    @SuppressFBWarnings("HSC_HUGE_SHARED_STRING_CONSTANT")
     @GdlGraph
     private static final String GDL = GraphSageTestGraph.GDL;
 

algo/src/test/java/org/neo4j/gds/leiden/FootballTest.java

@@ -19,7 +19,6 @@
  */
 package org.neo4j.gds.leiden;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.assertj.core.data.Offset;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -40,7 +39,6 @@
 @GdlExtension
 class FootballTest {
 
-    @SuppressFBWarnings("HSC_HUGE_SHARED_STRING_CONSTANT")
     @GdlGraph(orientation = Orientation.UNDIRECTED)
     public static final String GRAPH = TestGraphs.FOOTBALL_GRAPH;
 

algo/src/test/java/org/neo4j/gds/leiden/LocalMovePhaseKarateTest.java

@@ -19,7 +19,6 @@
  */
 package org.neo4j.gds.leiden;
 
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import org.junit.jupiter.api.Test;
 import org.neo4j.gds.Orientation;
 import org.neo4j.gds.collections.ha.HugeDoubleArray;
@@ -37,7 +36,6 @@
 @GdlExtension
 class LocalMovePhaseKarateTest {
 
-    @SuppressFBWarnings("HSC_HUGE_SHARED_STRING_CONSTANT")
     @GdlGraph(orientation = Orientation.UNDIRECTED)
     private static final String DB_CYPHER = TestGraphs.KARATE_CLUB_GRAPH;
 

alpha/alpha-proc/build.gradle

@@ -16,7 +16,6 @@ dependencies {
 
     compileOnly group: 'org.immutables', name: 'value-annotations', version: ver.'immutables'
     compileOnly group: 'org.jetbrains',  name: 'annotations',       version: ver.'jetbrains-annotations'
-    compileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
     neodeps().each {
         compileOnly(group: 'org.neo4j', name: it, version: ver.'neo4j') {
             transitive = false
@@ -46,7 +45,6 @@ dependencies {
     testCompileOnly group: 'org.immutables', name: 'value-annotations', version: ver.'immutables'
     testCompileOnly group: 'org.immutables', name: 'builder',           version: ver.'immutables'
     testCompileOnly group: 'org.jetbrains',  name: 'annotations',       version: ver.'jetbrains-annotations'
-    testCompileOnly group: 'com.github.spotbugs', name: 'spotbugs-annotations', version: ver.'spotbugsToolVersion'
 
     testImplementation project(':test-utils')
     testImplementation project(':proc-test')

build.gradle

@@ -3,7 +3,6 @@ plugins {
     id 'com.github.johnrengelman.shadow'            version '8.1.0'                 apply false
     id 'ch.kk7.spawn'                               version '1.0.20180924200750'    apply false
     id 'de.thetaphi.forbiddenapis'                  version '3.4'                   apply false
-    id 'com.github.spotbugs'                        version '5.0.13'                 apply false
     id 'nebula.info-dependencies'                   version '11.4.1'                 apply false
     id 'com.google.protobuf'                        version '0.9.4'                apply false
     id 'me.champeau.mrjar'                          version "0.1"                   apply false
@@ -21,9 +20,6 @@ ext {
 
     checkstyleReportsDir = "${buildDir}/reports/checkstyle/"
 
-    spotbugsReportsDir = "${buildDir}/reports/spotbugs/"
-    SpotBugsTask = com.github.spotbugs.snom.SpotBugsTask
-
     compatibilityModules = [
             'kernel-adapter': [
                     project(':neo4j-kernel-adapter-4.4'),
@@ -75,16 +71,11 @@ allprojects {
         description = "Run all checkstyle related tasks"
     }
 
-    tasks.register("spotbugs") {
-        group = "verification"
-        description = "Run all spotbugs related tasks"
-    }
 }
 
 apply from: 'gradle/dependencies.gradle'
 apply from: 'gradle/defaults-java.gradle'
 apply from: 'gradle/forbidden-apis.gradle'
 apply from: 'gradle/checkstyle.gradle'
-apply from: 'gradle/spotbugs.gradle'
 apply from: 'gradle/spotless.gradle'
 apply from: 'gradle/pregel-bootstrap.gradle'