Make it so that leaves with unknown volume get a volume when they finish

Co-Authored-By: Sören Reichardt <[email protected]>
Co-Authored-By: Adam Schill Collberg<[email protected]>

Author: breakanalysis

core/src/main/java/org/neo4j/gds/core/utils/progress/tasks/LeafTask.java

@@ -39,7 +39,7 @@ public void finish() {
 
         // This task should now be considered to have 100% progress.
         if (volume == UNKNOWN_VOLUME) {
-            volume = 0;
+            volume = currentProgress.longValue();
         }
         currentProgress.add(volume - currentProgress.longValue());
     }

core/src/test/java/org/neo4j/gds/core/utils/progress/tasks/TaskTest.java

@@ -221,10 +221,11 @@ void shouldSetProgressWhenFinishingTask() {
         task.start();
         var leaf1 = task.nextSubtask();
         leaf1.start();
-        leaf1.setVolume(22L);
+        leaf1.logProgress(22L);
         leaf1.finish();
 
         assertThat(leaf1.getProgress().progress()).isEqualTo(22L);
+        assertThat(leaf1.getProgress().volume()).isEqualTo(22L);
         assertThat(task.getProgress().volume()).isEqualTo(Task.UNKNOWN_VOLUME);
 
         var leaf2 = task.nextSubtask();
@@ -233,6 +234,7 @@ void shouldSetProgressWhenFinishingTask() {
         leaf2.finish();
 
         assertThat(leaf2.getProgress().progress()).isEqualTo(20L);
+        assertThat(leaf2.getProgress().volume()).isEqualTo(20L);
         assertThat(task.getProgress().volume()).isEqualTo(Task.UNKNOWN_VOLUME);
 
         task.finish();