From da0dc1bf1366a07f6789b809f621c7f2b7ce304e Mon Sep 17 00:00:00 2001 From: Eric Fernandez Date: Fri, 5 Apr 2013 22:07:11 -0700 Subject: [PATCH 1/4] Separated scripts to include with wp_enqueue_script for better compatibility --- gravityforms-placeholders.php | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/gravityforms-placeholders.php b/gravityforms-placeholders.php index ff41c4b..1776962 100755 --- a/gravityforms-placeholders.php +++ b/gravityforms-placeholders.php @@ -3,7 +3,7 @@ Plugin Name: Gravity Forms - Placeholders add-on Plugin URI: http://github.com/neojp/gravity-forms-placeholders/ Description: Adds HTML5 placeholder support to Gravity Forms' fields with a javascript fallback. Javascript & jQuery are required. -Version: 1.2.1 +Version: 1.2.2 Author: Joan Piedra Author URI: http://joanpiedra.com @@ -13,12 +13,19 @@ */ if ( isset( $GLOBALS['pagenow'] ) && $GLOBALS['pagenow'] == 'wp-login.php' ) - return; + return; + +// look into using wp_localize_script instead +function gf_placeholder_print_scripts() { + $plugin_dir = plugin_dir_url( __FILE__ ); + echo ""; +} + +add_action( 'wp_print_scripts', 'gf_placeholder_print_scripts' ); -add_action('wp_print_scripts', 'gf_placeholder_enqueue_scripts'); function gf_placeholder_enqueue_scripts() { - $plugin_url = plugins_url( basename(dirname(__FILE__)) ); - echo ""; - wp_enqueue_script('_gf_placeholders', $plugin_url . '/gf.placeholders.js', array('jquery'), '1.0' ); -} \ No newline at end of file + wp_enqueue_script( 'gf_placeholders', plugins_url( 'gf.placeholders.js', __FILE__ ), array( 'jquery' ), '1.0.1', true ); +} + +add_action( 'wp_enqueue_scripts', 'gf_placeholder_enqueue_scripts' ); From b28d4565d2df6bc92e480435f4ae9956d0ec372f Mon Sep 17 00:00:00 2001 From: Eric Fernandez Date: Mon, 4 Nov 2013 15:42:10 -0800 Subject: [PATCH 2/4] Fix for AJAX forms --- gf.placeholders.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gf.placeholders.js b/gf.placeholders.js index 5f57aeb..a867100 100755 --- a/gf.placeholders.js +++ b/gf.placeholders.js @@ -44,7 +44,7 @@ var gf_placeholder = function() { $(document).ready(function(){ gf_placeholder(); - $(document).bind('gform_page_loaded', gf_placeholder); + $(document).bind('gform_post_render', gf_placeholder); }); -})(jQuery); \ No newline at end of file +})(jQuery); From 4d754f744882e635c7745549da259289e077b239 Mon Sep 17 00:00:00 2001 From: Eric Fernandez Date: Tue, 3 Dec 2013 14:03:56 -0800 Subject: [PATCH 3/4] Make sure placeholder input is within a gravity form --- gf.placeholders.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gf.placeholders.js b/gf.placeholders.js index a867100..b7d729b 100755 --- a/gf.placeholders.js +++ b/gf.placeholders.js @@ -28,7 +28,9 @@ var gf_placeholder = function() { }); var support = (!('placeholder' in document.createElement('input'))); // borrowed from Modernizr.com - if ( support && jquery_placeholder_url ) + var placeholders = $('.gform_fields li.gplaceholder').length; + + if ( placeholders != 0 && support && jquery_placeholder_url ) { $.ajax({ cache: true, dataType: 'script', @@ -40,6 +42,7 @@ var gf_placeholder = function() { }, type: 'get' }); + } }; $(document).ready(function(){ From 3dda87eb35601ab4c6bc1bc77969ea6e8774a757 Mon Sep 17 00:00:00 2001 From: Eric Fernandez Date: Tue, 3 Dec 2013 14:04:41 -0800 Subject: [PATCH 4/4] bump version number --- gravityforms-placeholders.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gravityforms-placeholders.php b/gravityforms-placeholders.php index 1776962..71532c6 100755 --- a/gravityforms-placeholders.php +++ b/gravityforms-placeholders.php @@ -3,7 +3,7 @@ Plugin Name: Gravity Forms - Placeholders add-on Plugin URI: http://github.com/neojp/gravity-forms-placeholders/ Description: Adds HTML5 placeholder support to Gravity Forms' fields with a javascript fallback. Javascript & jQuery are required. -Version: 1.2.2 +Version: 1.2.3 Author: Joan Piedra Author URI: http://joanpiedra.com