Skip to content

Commit 170533d

Browse files
committed
feat(dcim): Enhance test data setup with multiple sites
Refactors tests to create multiple sites and assign devices accordingly. Updates CSV data to include `side_a_site` and `side_b_site` fields for scenarios involving multiple sites. This improves test coverage and alignment with real-world use cases.
1 parent 8aed482 commit 170533d

File tree

1 file changed

+15
-11
lines changed

1 file changed

+15
-11
lines changed

netbox/dcim/tests/test_views.py

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3266,17 +3266,21 @@ class CableTestCase(
32663266
@classmethod
32673267
def setUpTestData(cls):
32683268

3269-
site = Site.objects.create(name='Site 1', slug='site-1')
3269+
sites = (
3270+
Site(name='Site 1', slug='site-1'),
3271+
Site(name='Site 2', slug='site-2'),
3272+
)
3273+
Site.objects.bulk_create(sites)
32703274
manufacturer = Manufacturer.objects.create(name='Manufacturer 1', slug='manufacturer-1')
32713275
devicetype = DeviceType.objects.create(model='Device Type 1', manufacturer=manufacturer)
32723276
role = DeviceRole.objects.create(name='Device Role 1', slug='device-role-1')
32733277
vc = VirtualChassis.objects.create(name='Virtual Chassis')
32743278

32753279
devices = (
3276-
Device(name='Device 1', site=site, device_type=devicetype, role=role),
3277-
Device(name='Device 2', site=site, device_type=devicetype, role=role),
3278-
Device(name='Device 3', site=site, device_type=devicetype, role=role),
3279-
Device(name='Device 4', site=site, device_type=devicetype, role=role),
3280+
Device(name='Device 1', site=sites[0], device_type=devicetype, role=role),
3281+
Device(name='Device 2', site=sites[0], device_type=devicetype, role=role),
3282+
Device(name='Device 3', site=sites[0], device_type=devicetype, role=role),
3283+
Device(name='Device 1', site=sites[1], device_type=devicetype, role=role),
32803284
)
32813285
Device.objects.bulk_create(devices)
32823286

@@ -3328,12 +3332,12 @@ def setUpTestData(cls):
33283332
}
33293333

33303334
cls.csv_data = (
3331-
"side_a_device,side_a_type,side_a_name,side_b_device,side_b_type,side_b_name",
3332-
"Device 3,dcim.interface,Interface 1,Device 4,dcim.interface,Interface 1",
3333-
"Device 3,dcim.interface,Interface 2,Device 4,dcim.interface,Interface 2",
3334-
"Device 3,dcim.interface,Interface 3,Device 4,dcim.interface,Interface 3",
3335-
"Device 1,dcim.interface,Device 2 Interface,Device 4,dcim.interface,Interface 4",
3336-
"Device 1,dcim.interface,Device 3 Interface,Device 4,dcim.interface,Interface 5",
3335+
"side_a_site,side_a_device,side_a_type,side_a_name,side_b_site,side_b_device,side_b_type,side_b_name",
3336+
"Site 1,Device 3,dcim.interface,Interface 1,Site 2,Device 1,dcim.interface,Interface 1",
3337+
"Site 1,Device 3,dcim.interface,Interface 2,Site 2,Device 1,dcim.interface,Interface 2",
3338+
"Site 1,Device 3,dcim.interface,Interface 3,Site 2,Device 1,dcim.interface,Interface 3",
3339+
"Site 1,Device 1,dcim.interface,Device 2 Interface,Site 2,Device 1,dcim.interface,Interface 4",
3340+
"Site 1,Device 1,dcim.interface,Device 3 Interface,Site 2,Device 1,dcim.interface,Interface 5",
33373341
)
33383342

33393343
cls.csv_update_data = (

0 commit comments

Comments
 (0)