Skip to content

Commit 7e4799c

Browse files
bugfix in flags
1 parent 9758561 commit 7e4799c

File tree

2 files changed

+22
-15
lines changed

2 files changed

+22
-15
lines changed

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "netunicorn-library"
3-
version = "0.3.7"
3+
version = "0.3.8"
44
authors = [
55
{name = "Roman Beltiukov", email = "[email protected]"},
66
]

tasks/flags.py

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,13 @@ def run(self) -> FlagValues:
6060

6161
class WaitForExactFlagResultTask(Task):
6262
def __init__(
63-
self,
64-
flag_name: str,
65-
values: FlagValues,
66-
sleep_time: float = 1,
67-
attempts: Optional[int] = None,
68-
*args, **kwargs
63+
self,
64+
flag_name: str,
65+
values: FlagValues,
66+
sleep_time: float = 1,
67+
attempts: Optional[int] = None,
68+
*args,
69+
**kwargs,
6970
):
7071
self.flag_name = quote_plus_and_warn(flag_name)
7172
self.sleep_time = sleep_time
@@ -84,17 +85,17 @@ def run(self) -> FlagValues:
8485
result = None
8586
counter = 0
8687
while result != self.values:
87-
result = req.get(
88+
request_info = req.get(
8889
f"{gateway}/api/v1/experiment/{experiment_id}/flag/{self.flag_name}"
8990
)
90-
if result.status_code == 200:
91-
result = result.json()
91+
if request_info.status_code == 200:
92+
result = request_info.json()
9293
if result and FlagValues(**result) == self.values:
9394
break
9495

9596
# 404 is a normal result -- flag has not been set yet
96-
if result.status_code != 404:
97-
result.raise_for_status()
97+
if request_info.status_code != 404:
98+
request_info.raise_for_status()
9899

99100
counter += 1
100101
if self.attempts is not None and counter >= self.attempts:
@@ -105,7 +106,13 @@ def run(self) -> FlagValues:
105106

106107

107108
class _AtomicOperationFlagTask(Task):
108-
def __init__(self, flag_name: str, operation: Literal['increment', 'decrement'], *args, **kwargs):
109+
def __init__(
110+
self,
111+
flag_name: str,
112+
operation: Literal["increment", "decrement"],
113+
*args,
114+
**kwargs,
115+
):
109116
self.flag_name = quote_plus_and_warn(flag_name)
110117
self.operation = operation
111118
super().__init__(*args, **kwargs)
@@ -124,9 +131,9 @@ def run(self) -> None:
124131

125132
class AtomicIncrementFlagTask(_AtomicOperationFlagTask):
126133
def __init__(self, flag_name: str, *args, **kwargs):
127-
super().__init__(flag_name, 'increment', *args, **kwargs)
134+
super().__init__(flag_name, "increment", *args, **kwargs)
128135

129136

130137
class AtomicDecrementFlagTask(_AtomicOperationFlagTask):
131138
def __init__(self, flag_name: str, *args, **kwargs):
132-
super().__init__(flag_name, 'decrement', *args, **kwargs)
139+
super().__init__(flag_name, "decrement", *args, **kwargs)

0 commit comments

Comments
 (0)