diff --git a/.idea/inspectionProfiles/ktlint.xml b/.idea/inspectionProfiles/ktlint.xml
index f82b736f29a6..4aab2f7215ef 100644
--- a/.idea/inspectionProfiles/ktlint.xml
+++ b/.idea/inspectionProfiles/ktlint.xml
@@ -6,15 +6,19 @@
+
+
+
+
@@ -39,6 +43,7 @@
+
@@ -66,6 +71,7 @@
+
diff --git a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
index deb7568464bd..bc213a45b705 100644
--- a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
+++ b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
@@ -33,14 +33,13 @@ public static DataStorageProvider getInstance() {
private DataStorageProvider() {}
public StoragePoint[] getAvailableStoragePoints() {
- if (mCachedStoragePoints.size() != 0) {
+ if (!mCachedStoragePoints.isEmpty()) {
return mCachedStoragePoints.toArray(new StoragePoint[0]);
}
- List paths = new ArrayList<>();
StoragePoint storagePoint;
for (File f : MainApp.getAppContext().getExternalMediaDirs()) {
- if (f != null && !paths.contains(f.getAbsolutePath())) {
+ if (f != null) {
storagePoint = new StoragePoint();
storagePoint.setPath(f.getAbsolutePath());
storagePoint.setDescription(f.getAbsolutePath());
@@ -64,9 +63,7 @@ public StoragePoint[] getAvailableStoragePoints() {
storagePoint.setPath(MainApp.getAppContext().getFilesDir().getAbsolutePath());
storagePoint.setPrivacyType(StoragePoint.PrivacyType.PRIVATE);
storagePoint.setStorageType(StoragePoint.StorageType.INTERNAL);
- if (!paths.contains(MainApp.getAppContext().getFilesDir().getAbsolutePath())) {
- mCachedStoragePoints.add(storagePoint);
- }
+ mCachedStoragePoints.add(storagePoint);
// Add external storage directory if available.
if (isExternalStorageWritable()) {
@@ -80,25 +77,13 @@ public StoragePoint[] getAvailableStoragePoints() {
storagePoint.setDescription(externalFilesDirPath);
storagePoint.setPrivacyType(StoragePoint.PrivacyType.PRIVATE);
storagePoint.setStorageType(StoragePoint.StorageType.EXTERNAL);
- if (!paths.contains(externalFilesDirPath)) {
- mCachedStoragePoints.add(storagePoint);
- }
+ mCachedStoragePoints.add(storagePoint);
}
}
return mCachedStoragePoints.toArray(new StoragePoint[0]);
}
- public String getStorageDescriptionByPath(String path) {
- for (StoragePoint s : getAvailableStoragePoints()) {
- if (s.getPath().equals(path)) {
- return s.getDescription();
- }
- }
- // Fallback to just display complete path
- return path;
- }
-
/* Checks if external storage is available for read and write */
public boolean isExternalStorageWritable() {
String state = Environment.getExternalStorageState();