From 19b66802ebafd7eaa7cdc10a5425786d81073940 Mon Sep 17 00:00:00 2001
From: Alex <knopalex@msu.edu>
Date: Wed, 29 Oct 2025 20:08:15 -0400
Subject: [PATCH 1/2] removed empty paths ArrayList and logic that checked for
 its contents. Simplified checking size of UniqueStorageList

Signed-off-by: Alex <knopalex@msu.edu>
---
 .idea/inspectionProfiles/ktlint.xml                 |  6 ++++++
 .../android/datastorage/DataStorageProvider.java    | 13 ++++---------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/.idea/inspectionProfiles/ktlint.xml b/.idea/inspectionProfiles/ktlint.xml
index f82b736f29a6..4aab2f7215ef 100644
--- a/.idea/inspectionProfiles/ktlint.xml
+++ b/.idea/inspectionProfiles/ktlint.xml
@@ -6,15 +6,19 @@
     </inspection_tool>
     <inspection_tool class="ComposePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="ComposePreviewMustBeTopLevelFunction" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="ComposePreviewNeedsComposableAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="ComposePreviewNotSupportedInUnitTestFiles" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="GlancePreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="composableFile" value="true" />
@@ -39,6 +43,7 @@
     </inspection_tool>
     <inspection_tool class="PreviewDeviceShouldUseNewSpec" enabled="true" level="WEAK WARNING" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="PreviewDimensionRespectsLimit" enabled="true" level="WARNING" enabled_by_default="true">
       <option name="composableFile" value="true" />
@@ -66,6 +71,7 @@
     </inspection_tool>
     <inspection_tool class="PreviewParameterProviderOnFirstParameter" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="composableFile" value="true" />
+      <option name="previewFile" value="true" />
     </inspection_tool>
     <inspection_tool class="PreviewPickerAnnotation" enabled="true" level="ERROR" enabled_by_default="true">
       <option name="composableFile" value="true" />
diff --git a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
index deb7568464bd..33225c984a5d 100644
--- a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
+++ b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
@@ -33,14 +33,13 @@ public static DataStorageProvider getInstance() {
     private DataStorageProvider() {}
 
     public StoragePoint[] getAvailableStoragePoints() {
-        if (mCachedStoragePoints.size() != 0) {
+        if (!mCachedStoragePoints.isEmpty()) {
             return mCachedStoragePoints.toArray(new StoragePoint[0]);
         }
 
-        List<String> paths = new ArrayList<>();
         StoragePoint storagePoint;
         for (File f : MainApp.getAppContext().getExternalMediaDirs()) {
-            if (f != null && !paths.contains(f.getAbsolutePath())) {
+            if (f != null) {
                 storagePoint = new StoragePoint();
                 storagePoint.setPath(f.getAbsolutePath());
                 storagePoint.setDescription(f.getAbsolutePath());
@@ -64,9 +63,7 @@ public StoragePoint[] getAvailableStoragePoints() {
         storagePoint.setPath(MainApp.getAppContext().getFilesDir().getAbsolutePath());
         storagePoint.setPrivacyType(StoragePoint.PrivacyType.PRIVATE);
         storagePoint.setStorageType(StoragePoint.StorageType.INTERNAL);
-        if (!paths.contains(MainApp.getAppContext().getFilesDir().getAbsolutePath())) {
-            mCachedStoragePoints.add(storagePoint);
-        }
+        mCachedStoragePoints.add(storagePoint);
 
         // Add external storage directory if available.
         if (isExternalStorageWritable()) {
@@ -80,9 +77,7 @@ public StoragePoint[] getAvailableStoragePoints() {
                 storagePoint.setDescription(externalFilesDirPath);
                 storagePoint.setPrivacyType(StoragePoint.PrivacyType.PRIVATE);
                 storagePoint.setStorageType(StoragePoint.StorageType.EXTERNAL);
-                if (!paths.contains(externalFilesDirPath)) {
-                    mCachedStoragePoints.add(storagePoint);
-                }
+                mCachedStoragePoints.add(storagePoint);
             }
         }
 

From 2f8109b12f00812c6459927d1b1c554ab9470926 Mon Sep 17 00:00:00 2001
From: Alex <knopalex@msu.edu>
Date: Wed, 29 Oct 2025 20:11:15 -0400
Subject: [PATCH 2/2] remove unused function

Signed-off-by: Alex <knopalex@msu.edu>
---
 .../android/datastorage/DataStorageProvider.java       | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
index 33225c984a5d..bc213a45b705 100644
--- a/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
+++ b/app/src/main/java/com/owncloud/android/datastorage/DataStorageProvider.java
@@ -84,16 +84,6 @@ public StoragePoint[] getAvailableStoragePoints() {
         return mCachedStoragePoints.toArray(new StoragePoint[0]);
     }
 
-    public String getStorageDescriptionByPath(String path) {
-        for (StoragePoint s : getAvailableStoragePoints()) {
-            if (s.getPath().equals(path)) {
-                return s.getDescription();
-            }
-        }
-        // Fallback to just display complete path
-        return path;
-    }
-
     /* Checks if external storage is available for read and write */
     public boolean isExternalStorageWritable() {
         String state = Environment.getExternalStorageState();