ncp-config: fix empty values

Signed-off-by: nachoparker <[email protected]>

Author: nachoparker

bin/ncp-update-nc

@@ -181,10 +181,10 @@ find nextcloud/ -type f -exec chmod 640 {} \;
 echo "Upgrade..."
 ncc='sudo -u www-data php nextcloud/occ'
 $ncc upgrade      # && false # test point
-$ncc | grep -q db:add-missing-indices && $ncc db:add-missing-indices
-$ncc | grep -q db:add-missing-columns && $ncc db:add-missing-columns
-$ncc | grep -q db:add-missing-primary-keys && $ncc db:add-missing-primary-keys
-$ncc | grep -q db:convert-filecache-bigint && $ncc db:convert-filecache-bigint
+$ncc | grep -q db:add-missing-indices && $ncc db:add-missing-indices -n
+$ncc | grep -q db:add-missing-columns && $ncc db:add-missing-columns -n
+$ncc | grep -q db:add-missing-primary-keys && $ncc db:add-missing-primary-keys -n
+$ncc | grep -q db:convert-filecache-bigint && $ncc db:convert-filecache-bigint -n
 
 # done
 ####################

changelog.md

@@ -1,5 +1,7 @@
 
-[v1.33.1](https://github.com/nextcloud/nextcloudpi/commit/6891f49) (2020-12-12) nc-update-nc: improve error messages
+[v1.33.2](https://github.com/nextcloud/nextcloudpi/commit/1dc17a5) (2021-01-01) ncp-config: fix empty values
+
+[v1.33.1](https://github.com/nextcloud/nextcloudpi/commit/42fd597) (2020-12-12) nc-update-nc: improve error messages
 
 [v1.33.0](https://github.com/nextcloud/nextcloudpi/commit/ffd0b44) (2020-12-10) upgrade to NC20.0.3
 

etc/library.sh

@@ -40,14 +40,14 @@ function configure_app()
   [[ $len -eq 0 ]] && return
 
   # read cfg parameters
+  local parameters=()
   for (( i = 0 ; i < len ; i++ )); do
     local var="$(jq -r ".params[$i].id"    <<<"$cfg")"
     local val="$(jq -r ".params[$i].value" <<<"$cfg")"
     local vars+=("$var")
     local vals+=("$val")
     local idx=$((i+1))
-    [[ "$val" == "" ]] && val=_
-    local parameters+="$var $idx 1 $val $idx 15 60 120 "
+    parameters+=("$var" "$idx" 1 "$val" "$idx" 15 60 120)
   done
 
   # dialog
@@ -62,7 +62,7 @@ function configure_app()
     value="$( dialog --ok-label "Start" \
                      --no-lines --backtitle "$backtitle" \
                      --form "Enter configuration for $ncp_app" \
-                     20 70 0 $parameters \
+                     20 70 0 "${parameters[@]}" \
                3>&1 1>&2 2>&3 )"
     res=$?