Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Oct 22, 2025

Summary

best to review commit by commit

  • migrate services to Typescript
  • migrate components to Typescript (and script setup where feasible)
  • replace deprecated components removed in Vue 3 with their replacement
  • Adjust code to Vue 3
  • ❇️ added e2e tests to ensure we do not have regressions

ℹ️ This also contains two commits about the Vue 3 infrastructure I just noticed with a second app migrated (it worked with only one app before but now I had to adjust it for more apps to work).

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Oct 22, 2025
@susnux susnux added 3. to review Waiting for reviews feature: dav technical debt feature: vue apps ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Oct 22, 2025
@susnux susnux force-pushed the refactor/dav-vue3 branch from 547f7b7 to ceb8551 Compare October 22, 2025 23:41
@susnux susnux force-pushed the refactor/dav-vue3 branch 2 times, most recently from 9e32fe8 to b2aa080 Compare October 23, 2025 03:19
susnux added 11 commits October 23, 2025 05:21
rolldown is blocked by rolldown/rolldown#6670

Signed-off-by: Ferdinand Thiessen <[email protected]>
- migrate deprecated props
- use direct import of t rather than the mixin

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the refactor/dav-vue3 branch from b2aa080 to e91d4af Compare October 23, 2025 03:22
@susnux susnux marked this pull request as ready for review October 23, 2025 10:30
@susnux susnux requested review from a team as code owners October 23, 2025 10:30
@susnux susnux requested review from artonge, skjnldsv and szaimen and removed request for a team October 23, 2025 10:30
@susnux susnux requested review from leftybournes, salmart-dev and yemkareems and removed request for a team October 23, 2025 10:30
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux merged commit 5284241 into master Oct 23, 2025
207 of 211 checks passed
@susnux susnux deleted the refactor/dav-vue3 branch October 23, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: dav feature: vue apps ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants