Skip to content

Now using multiMap and regexp for post-fix removal #9287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

Now using multiMap and regexp for post-fix removal #9287

merged 1 commit into from
Oct 29, 2025

Conversation

@GallVp
Copy link
Member

@GallVp GallVp commented Oct 28, 2025

PR checklist

Closes #XXX

  • Now using multiMap and regexp for post-fix removal
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@GallVp GallVp requested a review from dialvarezs October 28, 2025 21:56
GallVp
GallVp commented Oct 28, 2025
View reviewed changes
subworkflows/nf-core/fasta_gxf_busco_plot/main.nf
ch_assembly_plot_summary = ch_assembly_short_summaries_txt
| map { meta, txt ->
def lineage_name = meta.lineage - '_odb'
def lineage_name = meta.lineage - ~/'_odb[0-9]+$'/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work for _odb12, etc.

dialvarezs
dialvarezs approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks way more clean now!
Thank you @GallVp!

@GallVp GallVp added this pull request to the merge queue Oct 29, 2025
Merged via the queue into nf-core:master with commit 488a964 Oct 29, 2025
19 checks passed
@GallVp GallVp deleted the update/fasta_gxf_busco_plot branch October 29, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dialvarezs dialvarezs dialvarezs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GallVp @dialvarezs