bugfix - image wont show when using local activestorage #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirzalazuardi
changed the title
|
Hi, Yep, ActiveStorage requires system level dependencies and libvips is the way to go. I've added that package to my own personal projects that use it. The concern here is not everyone uses ActiveStorage and including libvips increases the Docker image size. If we wanted to make ActiveStorage work out of the box for this example project it would require also adding new JavaScript dependencies for direct upload support and modifying the app JS code to include it. Maybe we can keep this PR open to see if others are interested in having ActiveStorage be included by default. If there's demand for that, I'd be happy to add it. |
|
Thanks... happy to help & contribute to your project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nickjj,
I found the issue when i using activestorage with disk service, and got me errors when i check on the image url.
The image also wont show on the web. But i already found a solution for this. which is to add some dependencies.
Please check my PR
Thanks