follow upstream changes

Author: bung87

compiler/sem/lookups.nim

@@ -502,8 +502,6 @@ proc wrongRedefinition*(
                         conflictsWith: PSym) =
   ## Emit a redefinition error if in non-interactive mode
   if c.config.cmd != cmdInteractive:
-    if sfTemplateParam in (s.flags + conflictsWith.flags):
-      return
     c.config.localReport(info, reportSymbols(
       rsemRedefinitionOf, @[s, conflictsWith]))
 

compiler/sem/semexprs.nim

@@ -1775,7 +1775,7 @@ proc builtinFieldAccess(c: PContext, n: PNode, flags: TExprFlags): PNode =
   when defined(nimsuggest):
     if c.config.cmd == cmdIdeTools:
       suggestExpr(c, n)
-      if n.len > 0 and c.config.m.trackPos == n[1].info: suggestExprNoCheck(c, n)
+      if c.config.m.trackPos == n[1].info: suggestExprNoCheck(c, n)
 
   let s = qualifiedLookUp(c, n, {checkAmbiguity, checkUndeclared, checkModule})
   if s.isError:

compiler/tools/suggest.nim

@@ -73,7 +73,7 @@ const
   sep = '\t'
 
 proc findDocComment(n: PNode): PNode =
-  if n == nil or n.kind == nkError: return nil
+  if n == nil: return nil
   if n.comment.len > 0: return n
   if n.kind in {nkStmtList, nkStmtListExpr, nkObjectTy, nkRecList} and n.len > 0:
     result = findDocComment(n[0])
@@ -543,7 +543,6 @@ proc suggestSym*(g: ModuleGraph; info: TLineInfo; s: PSym; usageSym: var PSym; i
     elif conf.ideCmd == ideHighlight and info.fileIndex == conf.m.trackPos.fileIndex:
       suggestResult(conf, symToSuggest(g, s, isLocal=false, ideHighlight, info, 100, PrefixMatch.None, false, 0))
     elif conf.ideCmd == ideOutline and isDecl and info.fileIndex == conf.m.trackPos.fileIndex:
-      if s.kind == skTemp or {sfGenSym, sfTemplateParam} * s.flags != {}: return
       if "`gensym" in s.name.s: return # prevent constant in template show up
       suggestResult(conf, symToSuggest(g, s, isLocal=false, ideOutline, info, 100, PrefixMatch.None, false, 0))