Skip to content

Commit f5ea8ad

Browse files
committed
docs(changeset): fix: type error web build
chore: update deps wrangler cloudflare fix: remove onAccountAdded since it doesn't work as expected. needed to remove window reload since returning to the page is handled by OAuth callback
1 parent 31292d6 commit f5ea8ad

File tree

6 files changed

+87
-79
lines changed

6 files changed

+87
-79
lines changed

.changeset/wide-views-fry.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@nimbus/web": patch
3+
---
4+
5+
fix: type error web build chore: update deps wrangler cloudflare fix: remove onAccountAdded since it doesn't work as
6+
expected. needed to remove window reload since returning to the page is handled by OAuth callback

apps/web/src/components/auth/signin-account-dialog.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@ import { Loader2 } from "lucide-react";
1212
type SigninAccountDialogProps = {
1313
open: boolean;
1414
onOpenChange: (open: boolean) => void;
15-
onAccountAdded: () => void;
1615
};
1716

18-
export function SigninAccountDialog({ open, onOpenChange, onAccountAdded }: SigninAccountDialogProps) {
17+
export function SigninAccountDialog({ open, onOpenChange }: SigninAccountDialogProps) {
1918
const isMounted = useIsMounted();
2019
const pathname = usePathname();
2120
const [callbackURL, setCallbackURL] = useState<string>("");
@@ -43,7 +42,6 @@ export function SigninAccountDialog({ open, onOpenChange, onAccountAdded }: Sign
4342
await signInWithMicrosoftProvider({ callbackURL });
4443
}
4544

46-
onAccountAdded();
4745
onOpenChange(false);
4846
} catch (error) {
4947
console.error(`Error signing in with ${provider}:`, error);

apps/web/src/components/providers/app-providers.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ function AuthWrapper({ children }: { children: ReactNode }) {
1515
return (
1616
<>
1717
{children}
18-
<SigninAccountDialog
19-
open={showSignIn}
20-
onOpenChange={open => (open ? openSignIn() : closeSignIn())}
21-
onAccountAdded={() => window.location.reload()}
22-
/>
18+
<SigninAccountDialog open={showSignIn} onOpenChange={open => (open ? openSignIn() : closeSignIn())} />
2319
</>
2420
);
2521
}

apps/web/src/hooks/useFileOperations.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ export function useDownloadFile() {
256256

257257
if (response.body && total > 0) {
258258
const reader = response.body.getReader();
259-
const chunks: Uint8Array[] = [];
259+
const chunks: BlobPart[] = [];
260260

261261
while (true) {
262262
const { done, value } = await reader.read();

0 commit comments

Comments
 (0)