http: allow proxies to be specified in common format

ethomson · ethomson · commit 7a901fb42f2e · 2023-08-02T21:36:30.000+01:00
The common format for specifying proxy URLs is just 'host:port'. Handle
the common case.
diff --git a/src/libgit2/transports/http.c b/src/libgit2/transports/http.c
@@ -335,7 +335,7 @@ static int lookup_proxy(
 	}
 
 	if (!proxy ||
-	    (error = git_net_url_parse(&transport->proxy.url, proxy)) < 0)
+	    (error = git_net_url_parse_http(&transport->proxy.url, proxy)) < 0)
 		goto done;
 
 	if (!git_net_url_valid(&transport->proxy.url)) {

Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,7 @@ static int lookup_proxy(`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`if (!proxy \|\|`
`338`		`- (error = git_net_url_parse(&transport->proxy.url, proxy)) < 0)`
	`338`	`+ (error = git_net_url_parse_http(&transport->proxy.url, proxy)) < 0)`
`339`	`339`	`goto done;`
`340`	`340`
`341`	`341`	`if (!git_net_url_valid(&transport->proxy.url)) {`