Skip to content

Commit eecb0d9

Browse files
committed
npm v12 removes command-line options
1 parent 46d7576 commit eecb0d9

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

.github/workflows/tests.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ jobs:
124124
with:
125125
python-version: ${{ matrix.python }}
126126
allow-prereleases: true
127+
- run: py --list-paths || true # Show all Python paths on Windows
127128
- uses: seanmiddleditch/gha-setup-ninja@v6
128129
- name: Install wasi-sdk (Windows)
129130
shell: pwsh
@@ -163,15 +164,19 @@ jobs:
163164
echo 'GYP_MSVS_OVERRIDE_PATH=C:\\Dummy' >> $Env:GITHUB_ENV
164165
- name: Run Python Tests
165166
run: python -m pytest
166-
- name: Run Tests (macOS or Linux)
167+
- name: Run Tests (Linux or macOS)
167168
if: runner.os != 'Windows'
168-
shell: bash
169-
run: npm test --python="${pythonLocation}/python"
170169
env:
171170
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}
171+
NODE_GYP_FORCE_PYTHON: "${{ env.pythonLocation }}/python"
172+
run: npm test
172173
- name: Run Tests (Windows)
173174
if: runner.os == 'Windows'
174175
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
175-
run: npm run test --python="${pythonLocation}\\python.exe"
176176
env:
177177
FULL_TEST: ${{ (matrix.node == '24.x' && matrix.python == '3.14') && '1' || '0' }}
178+
NODE_GYP_FORCE_PYTHON: "${{ env.pythonLocation }}\\python.exe"
179+
run: |
180+
echo "NODE_GYP_FORCE_PYTHON=${NODE_GYP_FORCE_PYTHON}"
181+
npm run test
182+

.github/workflows/visual-studio.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ jobs:
3333
python-version: "3.x"
3434
- name: Install Dependencies
3535
run: npm install
36+
- run: echo "env:pythonLocation=${env:pythonLocation}"
3637
- name: Run Node tests
37-
shell: pwsh
38-
run: npm run test --python="${env:pythonLocation}\\python.exe" --msvs-version="${{ matrix.msvs-version }}"
38+
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
39+
run: npm run test

0 commit comments

Comments
 (0)