Skip to content

Commit 4a13a62

Browse files
committed
crypto: always return certificate serial numbers as uppercase
This hides a discrepancy between OpenSSL and BoringSSL, as the latter returns lowercase hex values. Refs: #61459 (comment) PR-URL: #61752 Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent 8e561a3 commit 4a13a62

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/crypto/crypto_x509.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,8 @@ MaybeLocal<Value> GetSignatureAlgorithmOID(Environment* env,
253253

254254
MaybeLocal<Value> GetSerialNumber(Environment* env, const X509View& view) {
255255
if (auto serial = view.getSerialNumber()) {
256-
return OneByteString(env->isolate(),
257-
static_cast<unsigned char*>(serial.get()));
256+
return ToV8Value(
257+
env, ToUpper(std::string_view(static_cast<char*>(serial.get()))));
258258
}
259259
return Undefined(env->isolate());
260260
}

0 commit comments

Comments
 (0)