Implement handling of both new and old install method at the same time

This PR does the following:

- Creates two versions of the command handler (both inherits a base class where the implementation is).
- Uses a memory mapped file along with a mutex to communicate between the two, to have a shared counter.
- The counter value is used inside the classic version of the handler to determine if it should be shown or not.

By doing this, we can register both the new MSIX and the old registry on Windows 11, and ensure the following:
- If the MSIX registered entry is shown inside the classic menu, the old registry based one hides itself.
- If for some reason the MSIX registered entry doesn't show up inside the classic menu, the old registry based on shows itself.

From a users point of view - it "just works", and they always only see one entry in the old menu.

Fix notepad-plus-plus/notepad-plus-plus#13399
Close #20

Author: GurliGebis

EditWithNppExplorerCommandHandler.cpp renamed to BaseNppExplorerCommandHandler.cpp

@@ -1,40 +1,45 @@
 #include "pch.h"
-#include "EditWithNppExplorerCommandHandler.h"
+#include "BaseNppExplorerCommandHandler.h"
 
 #include "PathHelper.h"
 
 using namespace NppShell::CommandHandlers;
 using namespace NppShell::Helpers;
 
-const wstring EditWithNppExplorerCommandHandler::GetNppExecutableFullPath()
+BaseNppExplorerCommandHandler::BaseNppExplorerCommandHandler()
+{
+    counter = make_unique<SharedCounter>();
+}
+
+const wstring BaseNppExplorerCommandHandler::GetNppExecutableFullPath()
 {
     const wstring path = GetApplicationPath();
     const wstring fileName = L"\\notepad++.exe";
 
     return path + fileName;
 }
 
-const wstring EditWithNppExplorerCommandHandler::Title()
+const wstring BaseNppExplorerCommandHandler::Title()
 {
     return L"Edit with Notepad++";
 }
 
-const wstring EditWithNppExplorerCommandHandler::Icon()
+const wstring BaseNppExplorerCommandHandler::Icon()
 {
     const wstring fileName = GetNppExecutableFullPath();
 
     return fileName;
 }
 
-const wstring EditWithNppExplorerCommandHandler::GetCommandLine(const wstring& itemName)
+const wstring BaseNppExplorerCommandHandler::GetCommandLine(const wstring& itemName)
 {
     const wstring fileName = GetNppExecutableFullPath();
     const wstring parameters = L"\"" + itemName + L"\"";
 
     return L"\"" + fileName + L"\" " + parameters;
 }
 
-IFACEMETHODIMP EditWithNppExplorerCommandHandler::Invoke(IShellItemArray* psiItemArray, IBindCtx* pbc) noexcept try
+IFACEMETHODIMP BaseNppExplorerCommandHandler::Invoke(IShellItemArray* psiItemArray, IBindCtx* pbc) noexcept try
 {
     UNREFERENCED_PARAMETER(pbc);
 
@@ -87,4 +92,11 @@ IFACEMETHODIMP EditWithNppExplorerCommandHandler::Invoke(IShellItemArray* psiIte
 
     return S_OK;
 }
-CATCH_RETURN();
+CATCH_RETURN();
+
+const EXPCMDSTATE BaseNppExplorerCommandHandler::State(IShellItemArray* psiItemArray)
+{
+    UNREFERENCED_PARAMETER(psiItemArray);
+
+    throw L"State must be overridden in all implementations";
+}

EditWithNppExplorerCommandHandler.h renamed to BaseNppExplorerCommandHandler.h

@@ -1,24 +1,28 @@
 #pragma once
-#include "pch.h"
-
 #include "ExplorerCommandBase.h"
+#include "SharedCounter.h"
+
+using namespace NppShell::Helpers;
 
 namespace NppShell::CommandHandlers
 {
-#ifdef WIN64
-    class __declspec(uuid("B298D29A-A6ED-11DE-BA8C-A68E55D89593")) EditWithNppExplorerCommandHandler : public ExplorerCommandBase
-#else
-    class __declspec(uuid("00F3C2EC-A6EE-11DE-A03A-EF8F55D89593")) EditWithNppExplorerCommandHandler : public ExplorerCommandBase
-#endif
+    class BaseNppExplorerCommandHandler : public ExplorerCommandBase
     {
     public:
+        BaseNppExplorerCommandHandler();
+
         const wstring Title() override;
         const wstring Icon() override;
 
         IFACEMETHODIMP Invoke(IShellItemArray* psiItemArray, IBindCtx* pbc) noexcept override;
 
+        virtual const EXPCMDSTATE State(IShellItemArray* psiItemArray) override;
+
     private:
         const wstring GetNppExecutableFullPath();
         const wstring GetCommandLine(const wstring& itemName);
+
+    protected:
+        unique_ptr<SharedCounter> counter;
     };
 }

ClassicEditWithNppExplorerCommandHandler.cpp

@@ -0,0 +1,19 @@
+#include "pch.h"
+#include "ClassicEditWithNppExplorerCommandHandler.h"
+
+using namespace NppShell::CommandHandlers;
+
+const EXPCMDSTATE ClassicEditWithNppExplorerCommandHandler::State(IShellItemArray* psiItemArray)
+{
+    UNREFERENCED_PARAMETER(psiItemArray);
+
+    int state = counter->GetValue();
+
+    if (state == 3 || state == 5)
+    {
+        // This is on Windows 11, with both the modern and classic being shows, so we hide this one.
+        return ECS_HIDDEN;
+    }
+
+    return ECS_ENABLED;
+}

ClassicEditWithNppExplorerCommandHandler.h

@@ -0,0 +1,17 @@
+#pragma once
+#include "BaseNppExplorerCommandHandler.h"
+
+using namespace NppShell::Helpers;
+
+namespace NppShell::CommandHandlers
+{
+#ifdef WIN64
+    class __declspec(uuid("B298D29A-A6ED-11DE-BA8C-A68E55D89593")) ClassicEditWithNppExplorerCommandHandler : public BaseNppExplorerCommandHandler
+#else
+    class __declspec(uuid("00F3C2EC-A6EE-11DE-A03A-EF8F55D89593")) ClassicEditWithNppExplorerCommandHandler : public BaseNppExplorerCommandHandler
+#endif
+    {
+    public:
+        const EXPCMDSTATE State(IShellItemArray* psiItemArray);
+    };
+}

ExplorerCommandBase.cpp

@@ -8,13 +8,6 @@ const EXPCMDFLAGS ExplorerCommandBase::Flags()
     return ECF_DEFAULT;
 }
 
-const EXPCMDSTATE ExplorerCommandBase::State(IShellItemArray* psiItemArray)
-{
-    UNREFERENCED_PARAMETER(psiItemArray);
-
-    return ECS_ENABLED;
-}
-
 IFACEMETHODIMP ExplorerCommandBase::GetTitle(IShellItemArray* psiItemArray, LPWSTR* ppszName)
 {
     UNREFERENCED_PARAMETER(psiItemArray);
@@ -57,7 +50,8 @@ IFACEMETHODIMP ExplorerCommandBase::GetFlags(EXPCMDFLAGS* flags)
     return S_OK;
 }
 
-IFACEMETHODIMP ExplorerCommandBase::GetCanonicalName(GUID* pguidCommandName) {
+IFACEMETHODIMP ExplorerCommandBase::GetCanonicalName(GUID* pguidCommandName)
+{
     *pguidCommandName = GUID_NULL;
     return S_OK;
 }

ExplorerCommandBase.h

@@ -9,7 +9,7 @@ namespace NppShell::CommandHandlers
         virtual const wstring Title() = 0;
         virtual const wstring Icon() = 0;
         virtual const EXPCMDFLAGS Flags();
-        virtual const EXPCMDSTATE State(IShellItemArray* psiItemArray);
+        virtual const EXPCMDSTATE State(IShellItemArray* psiItemArray) = 0;
 
         IFACEMETHODIMP GetTitle(IShellItemArray* psiItemArray, LPWSTR* ppszName);
         IFACEMETHODIMP GetIcon(IShellItemArray* psiItemArray, LPWSTR* ppszIcon);

Installer.cpp

@@ -1,7 +1,7 @@
 #include "pch.h"
 #include "Installer.h"
 
-#include "EditWithNppExplorerCommandHandler.h"
+#include "ClassicEditWithNppExplorerCommandHandler.h"
 #include "PathHelper.h"
 #include "AclHelper.h"
 
@@ -65,7 +65,7 @@ bool IsWindows11Installation()
 
 wstring GetCLSIDString()
 {
-    const auto uuid = __uuidof(NppShell::CommandHandlers::EditWithNppExplorerCommandHandler);
+    const auto uuid = __uuidof(NppShell::CommandHandlers::ClassicEditWithNppExplorerCommandHandler);
 
     LPOLESTR guidString = 0;
     const HRESULT result = StringFromCLSID(uuid, &guidString);
@@ -360,10 +360,8 @@ HRESULT NppShell::Installer::Install()
 
         result = RegisterSparsePackage();
     }
-    else
-    {
-        result = RegisterOldContextMenu();
-    }
+
+    result = RegisterOldContextMenu();
 
     // Ensure we schedule old files for removal on next reboot.
     MoveFileToTempAndScheduleDeletion(GetApplicationPath() + L"\\NppShell_01.dll", false);

ModernEditWithNppExplorerCommandHandler.cpp

@@ -0,0 +1,11 @@
+#include "pch.h"
+#include "ModernEditWithNppExplorerCommandHandler.h"
+
+using namespace NppShell::CommandHandlers;
+
+const EXPCMDSTATE ModernEditWithNppExplorerCommandHandler::State(IShellItemArray* psiItemArray)
+{
+    UNREFERENCED_PARAMETER(psiItemArray);
+
+    return ECS_ENABLED;
+}

ModernEditWithNppExplorerCommandHandler.h

@@ -0,0 +1,13 @@
+#pragma once
+#include "BaseNppExplorerCommandHandler.h"
+
+using namespace NppShell::Helpers;
+
+namespace NppShell::CommandHandlers
+{
+    class __declspec(uuid("E6950302-61F0-4FEB-97DB-855E30D4A991")) ModernEditWithNppExplorerCommandHandler : public BaseNppExplorerCommandHandler
+    {
+    public:
+        const EXPCMDSTATE State(IShellItemArray* psiItemArray);
+    };
+}

NppShell.vcxproj

@@ -263,19 +263,24 @@
   </ItemDefinitionGroup>
   <ItemGroup>
     <ClInclude Include="AclHelper.h" />
-    <ClInclude Include="EditWithNppExplorerCommandHandler.h" />
+    <ClInclude Include="BaseNppExplorerCommandHandler.h" />
+    <ClInclude Include="ClassicEditWithNppExplorerCommandHandler.h" />
     <ClInclude Include="ExplorerCommandBase.h" />
     <ClInclude Include="framework.h" />
+    <ClInclude Include="ModernEditWithNppExplorerCommandHandler.h" />
     <ClInclude Include="PathHelper.h" />
     <ClInclude Include="Installer.h" />
     <ClInclude Include="pch.h" />
+    <ClInclude Include="SharedCounter.h" />
     <ClInclude Include="SimpleFactory.h" />
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="AclHelper.cpp" />
+    <ClCompile Include="BaseNppExplorerCommandHandler.cpp" />
+    <ClCompile Include="ClassicEditWithNppExplorerCommandHandler.cpp" />
     <ClCompile Include="dllmain.cpp" />
-    <ClCompile Include="EditWithNppExplorerCommandHandler.cpp" />
     <ClCompile Include="ExplorerCommandBase.cpp" />
+    <ClCompile Include="ModernEditWithNppExplorerCommandHandler.cpp" />
     <ClCompile Include="PathHelper.cpp" />
     <ClCompile Include="Installer.cpp" />
     <ClCompile Include="pch.cpp">
@@ -286,6 +291,7 @@
       <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">Create</PrecompiledHeader>
       <PrecompiledHeader Condition="'$(Configuration)|$(Platform)'=='Release|ARM64'">Create</PrecompiledHeader>
     </ClCompile>
+    <ClCompile Include="SharedCounter.cpp" />
   </ItemGroup>
   <ItemGroup>
     <None Include="packages.config" />