Skip to content

Commit e92a7d2

Browse files
committed
Revert "fix(expo): prioritize package.json over graph for version detection"
This reverts commit 45c2f50.
1 parent 45c2f50 commit e92a7d2

File tree

4 files changed

+27
-31
lines changed

4 files changed

+27
-31
lines changed

packages/expo/migrations.json

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -190,23 +190,23 @@
190190
"alwaysAddToPackageJson": false
191191
},
192192
"expo-splash-screen": {
193-
"version": "~0.31.0",
193+
"version": "~31.0.11",
194194
"alwaysAddToPackageJson": false
195195
},
196196
"expo-status-bar": {
197-
"version": "~3.0.0",
197+
"version": "~3.0.8",
198198
"alwaysAddToPackageJson": false
199199
},
200200
"expo-system-ui": {
201-
"version": "~6.0.0",
201+
"version": "~6.0.8",
202202
"alwaysAddToPackageJson": false
203203
},
204204
"@expo/cli": {
205-
"version": "~0.26.0",
205+
"version": "~54.0.16",
206206
"alwaysAddToPackageJson": false
207207
},
208208
"babel-preset-expo": {
209-
"version": "~14.0.0",
209+
"version": "~54.0.7",
210210
"alwaysAddToPackageJson": false
211211
},
212212
"react": {
@@ -222,19 +222,19 @@
222222
"alwaysAddToPackageJson": false
223223
},
224224
"react-native": {
225-
"version": "~0.81.4",
225+
"version": "~0.81.5",
226226
"alwaysAddToPackageJson": false
227227
},
228228
"react-native-web": {
229229
"version": "~0.21.0",
230230
"alwaysAddToPackageJson": false
231231
},
232232
"@expo/metro-config": {
233-
"version": "~0.22.0",
233+
"version": "~54.0.9",
234234
"alwaysAddToPackageJson": false
235235
},
236236
"@expo/metro-runtime": {
237-
"version": "~6.0.0",
237+
"version": "~6.1.2",
238238
"alwaysAddToPackageJson": false
239239
},
240240
"react-native-svg-transformer": {
@@ -250,7 +250,7 @@
250250
"alwaysAddToPackageJson": false
251251
},
252252
"jest-expo": {
253-
"version": "~54.0.0",
253+
"version": "~54.0.13",
254254
"alwaysAddToPackageJson": false
255255
},
256256
"@babel/runtime": {

packages/expo/src/generators/library/library.spec.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -563,8 +563,8 @@ describe('lib', () => {
563563
"main": "./src/index.ts",
564564
"name": "@proj/my-lib",
565565
"peerDependencies": {
566-
"react": "^19.1.0",
567-
"react-native": "0.81.4",
566+
"react": "19.1.0",
567+
"react-native": "0.81.5",
568568
},
569569
"types": "./src/index.ts",
570570
"version": "0.0.1",
@@ -696,8 +696,8 @@ describe('lib', () => {
696696
"module": "./dist/index.esm.js",
697697
"name": "@proj/my-lib",
698698
"peerDependencies": {
699-
"react": "^19.1.0",
700-
"react-native": "0.81.4",
699+
"react": "19.1.0",
700+
"react-native": "0.81.5",
701701
},
702702
"types": "./dist/index.esm.d.ts",
703703
"version": "0.0.1",

packages/expo/src/utils/version-utils.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,9 @@ export async function getExpoDependenciesVersionsToInstall(
129129
* Check if the workspace is using Expo v53.
130130
*/
131131
export async function isExpoV53(tree: Tree): Promise<boolean> {
132-
// Check package.json first (faster and works during workspace creation)
133-
let installedExpoVersion = getInstalledExpoVersion(tree);
132+
let installedExpoVersion = await getInstalledExpoVersionFromGraph();
134133
if (!installedExpoVersion) {
135-
// Fallback to project graph if package.json doesn't have it
136-
installedExpoVersion = await getInstalledExpoVersionFromGraph();
134+
installedExpoVersion = getInstalledExpoVersion(tree);
137135
}
138136
if (!installedExpoVersion) {
139137
return false; // No Expo installed, default to latest
@@ -145,11 +143,9 @@ export async function isExpoV53(tree: Tree): Promise<boolean> {
145143
* Check if the workspace is using Expo v54.
146144
*/
147145
export async function isExpoV54(tree: Tree): Promise<boolean> {
148-
// Check package.json first (faster and works during workspace creation)
149-
let installedExpoVersion = getInstalledExpoVersion(tree);
146+
let installedExpoVersion = await getInstalledExpoVersionFromGraph();
150147
if (!installedExpoVersion) {
151-
// Fallback to project graph if package.json doesn't have it
152-
installedExpoVersion = await getInstalledExpoVersionFromGraph();
148+
installedExpoVersion = getInstalledExpoVersion(tree);
153149
}
154150
if (!installedExpoVersion) {
155151
return true; // No Expo installed, default to latest (v54)

packages/expo/src/utils/versions.ts

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,18 @@ export const nxVersion = require('../../package.json').version;
22

33
// Expo v54 versions (default for new projects)
44
export const expoV54Version = '~54.0.0';
5-
export const expoV54SplashScreenVersion = '~0.31.0';
6-
export const expoV54StatusBarVersion = '~3.0.0';
7-
export const expoV54SystemUiVersion = '~6.0.0';
8-
export const expoV54CliVersion = '~0.26.0'; // @expo/cli
9-
export const babelPresetExpoV54Version = '~14.0.0';
10-
export const expoV54MetroConfigVersion = '~0.22.0';
11-
export const expoV54MetroRuntimeVersion = '~6.0.0';
12-
export const jestExpoV54Version = '~54.0.0';
5+
export const expoV54SplashScreenVersion = '~31.0.11';
6+
export const expoV54StatusBarVersion = '~3.0.8';
7+
export const expoV54SystemUiVersion = '~6.0.8';
8+
export const expoV54CliVersion = '~54.0.16';
9+
export const babelPresetExpoV54Version = '~54.0.7';
10+
export const expoV54MetroConfigVersion = '~54.0.9';
11+
export const expoV54MetroRuntimeVersion = '~6.1.2';
12+
export const jestExpoV54Version = '~54.0.13';
1313
export const reactV54Version = '^19.1.0';
1414
export const reactDomV54Version = '^19.1.0';
15-
export const typesReactV54Version = '~19.1.0';
16-
export const reactNativeV54Version = '0.81.4';
15+
export const typesReactV54Version = '^19.1.0';
16+
export const reactNativeV54Version = '0.81.5';
1717
export const metroV54Version = '~0.83.0';
1818
export const reactNativeWebV54Version = '~0.21.0';
1919

0 commit comments

Comments
 (0)