fix(nx): optimize bun lockfile parser with O(1) lookups: 7x faster #33623
+371
−381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Key Optimizations Made 1. Pre-computed PackageIndex - Built once during lockfile parsing: - byName: Map from package name → array of versions (O(1) lookup) - workspaceNames: Set of workspace package names (O(1) lookup) - workspacePaths: Set of workspace paths (O(1) lookup) - packagesWithWorkspaceVariants: Set of packages with workspace-specific variants (O(1) lookup) - patchedPackages: Set of patched package names (O(1) lookup) 2. findResolvedVersion: Changed from O(n) scan through all packages to O(1) map lookup + O(k) where k = number of versions for that package (typically 1-3) 3. isWorkspacePackage: Changed from O(n) scan to O(1) set lookup 4. hasWorkspaceSpecificVariant: Changed from O(n) scan to O(1) set lookup 5. isNestedPackageKey: Now uses pre-computed workspace paths/names sets instead of computing them each call
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
berenddeboer
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| const prefix = packageKey.substring(0, lastSlash); | ||
|
|
||
| // If the prefix is a workspace path or scoped package pattern | ||
| if (workspacePaths.has(prefix) || prefix.startsWith('@')) { |
Contributor
There was a problem hiding this comment.
Missing condition in workspace variant detection. The old logic checked prefix.startsWith('@') && prefix.includes('/') but the new code only checks prefix.startsWith('@'). This could incorrectly identify packages as workspace-specific variants.
For example, if a package key is split where the prefix is just @scope (without a slash), it would incorrectly match, whereas the old code would reject it.
Fix:
if (workspacePaths.has(prefix) || (prefix.startsWith('@') && prefix.includes('/'))) {
packagesWithWorkspaceVariants.add(possiblePackageName);
}
Suggested change
| if (workspacePaths.has(prefix) || prefix.startsWith('@')) { | |
| if (workspacePaths.has(prefix) || (prefix.startsWith('@') && prefix.includes('/'))) { |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
We fixed two related bugs in the workspace variant detection logic:
Bug 1: buildPackageIndex - Missing condition in workspace variant detection
Location: packages/nx/src/plugins/js/lock-file/bun-parser.ts:492
Problem: The check prefix.startsWith('@') was missing the additional condition
prefix.includes('/'). This could incorrectly identify packages as workspace-specific
variants when the prefix is just @scope (without a slash).
Bug 2: isNestedPackageKey - Scoped packages incorrectly filtered as nested
Location: packages/nx/src/plugins/js/lock-file/bun-parser.ts:1200-1205
Problem: The function's final return true would incorrectly filter legitimate scoped
packages like @types/react or scoped aliases like @custom/lodash as nested packages.
Fix: Added a check before the final return true to recognize simple scoped packages
(2-part keys starting with @).
berenddeboer
changed the title
Contributor
|
🥺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key optimisations:
On my 40 project typescript monorepo my time goes from about 30 seconds to 4.5s, a speed-up of 6-7x.