Skip to content

Commit 92d64de

Browse files
committed
Fixes for Python 3.9
Signed-off-by: Sreekanth <prsreekanth920@gmail.com>
1 parent ec48803 commit 92d64de

2 files changed

Lines changed: 13 additions & 11 deletions

File tree

pynumaflow/sourcer/_dtypes.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def offsets(self) -> list[Offset]:
169169
return self._offsets
170170

171171

172-
@dataclass(slots=True)
172+
@dataclass
173173
class NackRequest:
174174
"""
175175
Class for defining the request for negatively acknowledging an offset.
@@ -182,8 +182,17 @@ class NackRequest:
182182
>>> nack_request = NackRequest(offsets=[offset_val, offset_val])
183183
"""
184184

185+
__slots__ = ("_offsets",)
185186
offsets: list[Offset]
186187

188+
def __init__(self, offsets: list[Offset]):
189+
self._offsets = offsets
190+
191+
@property
192+
def offsets(self) -> list[Offset]:
193+
"""Returns the offsets to be negatively acknowledged."""
194+
return self._offsets
195+
187196

188197
@dataclass(init=False)
189198
class PendingResponse:

tests/source/test_async_source_err.py

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,6 @@ def test_read_error(self) -> None:
9292
)
9393
for _ in generator_response:
9494
pass
95-
except BaseException as e:
96-
self.assertTrue(
97-
f"{ERR_UDF_EXCEPTION_STRING}: TypeError("
98-
'"handle_async_error() missing 1 required positional argument: '
99-
"'exception_type'\")" in e.__str__()
100-
)
101-
return
10295
except grpc.RpcError as e:
10396
grpc_exception = e
10497
self.assertEqual(grpc.StatusCode.UNKNOWN, e.code())
@@ -138,12 +131,12 @@ def test_ack_error(self) -> None:
138131
resp = stub.AckFn(request_iterator=request_generator(1, request, "ack"))
139132
for _ in resp:
140133
pass
141-
except BaseException as e:
142-
self.assertTrue("Got a runtime error from ack handler." in e.__str__())
143-
return
144134
except grpc.RpcError as e:
145135
self.assertEqual(grpc.StatusCode.UNKNOWN, e.code())
146136
print(e.details())
137+
except BaseException as e:
138+
self.assertTrue("Got a runtime error from ack handler." in e.__str__())
139+
return
147140
self.fail("Expected an exception.")
148141

149142
def test_ack_no_handshake_error(self) -> None:

0 commit comments

Comments
 (0)