Fix: color theme examples #1925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The color theme examples in book/coloring_and_theming.md weren't quite right.
fdncred
reviewed
May 27, 2025
NailFec
reviewed
Aug 21, 2025
book/coloring_and_theming.md
Outdated
| $env.config = { | ||
| # ... | ||
| color_config: (light_theme) # if you want a light theme, replace `$dark_theme` to `$light_theme` | ||
| color_config: (light-theme) # if you want a light theme, replace `$dark_theme` to `$light_theme` |
There was a problem hiding this comment.
I think this comment is misleading. It appears to be a leftover from nushell PR #5804, which modified default_config.nu. However, that file has since been deprecated. I suggest removing this comment or changing it, as it no longer reflects the current state of the configuration.
Suggested change
| color_config: (light-theme) # if you want a light theme, replace `$dark_theme` to `$light_theme` | |
| color_config: (light-theme) |
There was a problem hiding this comment.
I think (light-theme) or (dark-theme) will work as long as they're brought into scope with use.
fdncred
reviewed
Aug 21, 2025
fdncred
reviewed
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color theme examples in book/coloring_and_theming.md weren't quite right.