Upstream nvim at 23fe6dba1 breaks tab completion

[arsham]

My testing minimal init.vim
The part of the mapping that is relevant:

require('astronauta.keymap')
vim.keymap.inoremap{'<Tab>',   require("completion").smart_tab,   buffer=true, silent=true}
vim.keymap.inoremap{'<S-Tab>', require("completion").smart_s_tab, buffer=true, silent=true}

How to reproduce
Compile the upstream at this commit. Use tab completion.

Expected behaviour
Completion popup to show up, but it doesn't.

I can confirm that completion works at this commit.

[stormc]

The handler function's signature in source/lsp.lua needs to be updated, possibly adding a backwards-compatible wrapper for neovim versions prior to this commit. As an intermediate hack, this should help:

-  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, _, result)
+  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, result)

[mrkz]

@stormc thanks for the workaround, looking forward to the fix 😄

[stormc]

@mrkz You're welcome, #400 does also proper-fix hover and signature for which you would have to apply this workaround's gist as well, so I suggest to use that instead of this workaround until it's been merged.