Deleting nested tags in html

[redoxahmii]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.surround

Question

Currently if i try to delete a surrounding using mini.ai text objects for a nested tag it tends to not work unless there is a different tag inside it from it's ancestor.
for example:

<div>
  <div>
    <p>Hello world</p>
  </div>
</div>

In this it would only delete the second <div> tag as the tag inside is different. Now if I add :

<div>
  <p>Another hello world</p>
  <div>
    <p>Hello world</p>
  </div>
</div>

This will now properly delete the <div> tags when my cursor is on both.
Is this the intended behavior?
Also is it possible to pass some kind of motion instead of deleting and adding?
My use case in this regard is to comment those tags instead of removing them completely.

Thank you!

[echasnovski]

Sorry, this is a bit confusing:

Currently if i try to delete a surrounding using mini.ai text objects for a nested tag it tends to not work unless there is a different tag inside it from it's ancestor.

This indicates that the problem is with 'mini.ai'...

Also is it possible to pass some kind of motion instead of deleting and adding?
My use case in this regard is to comment those tags instead of removing them completely.

... but the chosen "Module" and this question indicate that the issue is with 'mini.surround'. I suspect the question is indeed for 'mini.surround' and you try to delete tags with sdt. Although he answer is similar in both cases.

This is a known limitation of how 'mini.surround' and 'mini.ai' find surroundings/textobjects. They use Lua patterns which has limitations when it comes to parsing structured data. See #755 for 'mini.surround' and #735 for 'mini.ai'. The suggested solution is mentioned in the issues and is basically "use tree-sitter based specification for tag surrounding/textobject".

---

To answer about available actions on surroundings, instead of only delete and add, these actions are available. In this particular case the closes I can suggest is to replace with interactive surrounding, but it requires typing left and right part in full. So something like this:

• sr -> t to replace tag surrounding.
• ? -> (enter new left surrounding) <!-- <div> --> - <CR> -> (enter new right surrounding) <!-- </div> --> -> <CR>.

Another approach might be using marks and "find" action:

• sft to navigate to right surrounding.
• ma to add mark a.
• sFt to navigate to left surrounding.
• gcc to comment it out.
• 'a to navigate to back to right surrounding.
• gcc to comment it out.

The second approach is a bit more complicated but probably can be automated into mapping (don't forget to set remap = true) and doesn't require typing out left and right surroundings.

[redoxahmii]

My fault for not articulating the problem properly as I was unsure frankly if this issue comes from mini.ai or mini.surround.

I'll see if using the treesitter approach is suitable for me or not.

One question regarding this and this is purely for my own better understanding why choose lua patterns over Treesitter captures in this scenario?
I would assume it to be far less annoying to use the AST instead of patterns which one way or the other are going to have false positives.
Thank you for the quick response.

[echasnovski]

One question regarding this and this is purely for my own better understanding why choose lua patterns over Treesitter captures in this scenario?

As for any other built-in surrounding/textobject: to be able to work if there is no tree-sitter available and in the regions where tree-sitter doesn't work (like comments and strings).

[redoxahmii]

Treesitter has given me a lot of grief when working with comment nodes so that makes more sense.
Thank you.