Snippet Expansion Removes Closing Parenthesis When Triggered with ;

[krovuxdev]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.snippets

Question

I'm using blink.cmp with mini.snippet. The issue occurs when I use ; to trigger snippet completion. If I type (;fu), after expansion, the output is:

(function()

end

The closing ) gets deleted. However, without ;, the ) remains intact.

I suspect the issue comes from blink.cmp's snippet handling, specifically in mini_snippet.lua, Below is my configuration:

My Code

  transform_items = function(_, items)
                local col = vim.api.nvim_win_get_cursor(0)[2]
                local before_cursor = vim.api.nvim_get_current_line():sub(1, col)
                local pos = before_cursor:find(";[%w*]*$")
                -- if not pos then return items end
                if not pos then
                    return vim.tbl_filter(function(item)
                        return item.kind ~= require('blink.cmp.types').CompletionItemKind.Snippet
                    end, items)
                end
                for _, item in ipairs(items) do
                    item.textEdit = {
                        newText = item.insertText or item.label,
                        range = {
                            start = {
                                line = vim.fn.line(".") - 1,
                                character = pos - 1,

                            },
                            ["end"] = {
                                line = vim.fn.line(".") - 1,
                                character = col,
                            },
                        },
                    }

                end

                return vim.tbl_filter(function(item)
                    local kind_snippet = require('blink.cmp.types').CompletionItemKind.Snippet
                    return pos and item.kind == kind_snippet
                end, items)
            end,

I'm unsure how to fix this for a PR to mini_snippet.lua. Any guidance on why the ) is being deleted and how to properly handle snippet expansion with ; would be helpful.

[echasnovski]

My first thought is that that is a result of how 'Saghen/blink.cmp' (and 'hrsh7th/nvim-cmp', for that matter) handle combination of additionalTextEdits / textEdit and snippet expansion. The root cause for this seems to be that 'mini.snippets' always operates in Insert mode which can cause some issues with asynchronous execution (i.e. which text is current at the time of some steps executed). See more information at abeldekat/cmp-mini-snippets#9 and saghen/blink.cmp#1035.

The second thought is that this might be a consequence of the custom transform_items conflicting with this part of the 'blink.cmp'.

As this is seems to be more of a not 'mini.snippets' question, I am going to close this. If there will be concrete question about how 'mini.snippets' operates, feel free to ask here.

---

I hope to soon update 'mini.snippets' with a way to suggest its entries via an in-process LSP server. Then it can be used with a regular LSP server handling. Not sure if that would help with this custom "; to trigger snippets" approach.

[krovuxdev]

Finally, I found the solution! The missing part was adding:

vim.schedule(function()
    require("blink.cmp").reload()
end)

It turns out that calling reload() ensures the snippet resets properly, and now it works as expected.

Thank you so much, @echasnovski Your explanation helped me understand the different edge cases in blink.cmp and nvim-cmp.

My Code:

   transform_items = function(_, items)
                local col = vim.api.nvim_win_get_cursor(0)[2]
                local before_cursor = vim.api.nvim_get_current_line():sub(1, col)
                local pos = before_cursor:find(";[%w*]*$")
                local reload = function()
                    vim.schedule(function()
                        require("blink.cmp").reload()
                    end)
                end
                -- if not pos then return items end
                if not pos then
                    return vim.tbl_filter(function(item)
                        reload()
                        return item.kind
                            ~= require("blink.cmp.types").CompletionItemKind.Snippet
                    end, items)
                end
                for _, item in ipairs(items) do
                    item.textEdit = {
                        newText = item.insertText or item.label,
                        range = {
                            start = {
                                line = vim.fn.line(".") - 1,
                                character = pos - 1,
                            },
                            ["end"] = {
                                line = vim.fn.line(".") - 1,
                                character = col,
                            },
                        },
                    }
                end
                return vim.tbl_filter(function(item)
                    reload()
                    local kind_snippet = require("blink.cmp.types").CompletionItemKind.Snippet
                    return pos and item.kind == kind_snippet
                end, items)
            end,

My apologies for opening a discussion that wasn’t directly related to mini.snippet.

[echasnovski]

Thank you so much, @echasnovski Your explanation helped me understand the different edge cases in blink.cmp and nvim-cmp.

I can't have any credit here. All goes to @abeldekat for dealing with these issues.

My apologies for opening a discussion that wasn’t directly related to mini.snippet.

No worries. You didn't know about that and it wasn't exactly obvious.

---

One small improvement for local reload = ... part is to use vim.schedule_wrap:

                local reload = vim.schedule_wrap(require("blink.cmp").reload)

Or just use vim.schedule(require("blink.cmp").reload) directly both times. Depends on style preferences.

[krovuxdev]

One small improvement for local reload = ... part is to use vim.schedule_wrap:

                local reload = vim.schedule_wrap(require("blink.cmp").reload)

Or just use vim.schedule(require("blink.cmp").reload) directly both times. Depends on style preferences.

Thank you! That was useful, and it worked for me. :)