[mini.surround] Preserve cursor position

[farooqameen]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.surround

Question

Hello!

When using saiw" to add double-quotes, the cursor is moved to the start of the word, as show below:

From my understanding, this is the default behavior of the iw motion.

I would prefer that the cursor stays at the same position, regardless of the motion. I don't understand how to approach this problem - should I use markers, should I save the cursor position before Minisurround.add(), or...?

Any guidance would be appreciated!

[echasnovski]

Hi!

When using saiw" to add double-quotes, the cursor is moved to the start of the word, as show below:

For reference: this is intended. #1409 contains links to more details.

I would prefer that the cursor stays at the same position, regardless of the motion. I don't understand how to approach this problem - should I use markers, should I save the cursor position before Minisurround.add(), or...?

My honest suggestion would be to just get used to it, because this is consistent with the built-in behavior (like with yiw, guiw or any built-in operator). If the latter will change in the future, so will sa operator.

As to pointers... All of them will be hacky and potentially not reliable in the long term and/or quite convoluted (because Vim's operator implementation is). You can indeed try to copy the 'mini.surround' approach:

• This creates expression mapping.
• This creates function right hand side. Here instead of vim.o.operatorfunc = 'v:lua.MiniSurround.add' use something like v:lua.my_surround_add which caches cursor position, calls MiniSurround.add(), and restores cached cursor position.

Hope this helps.

[farooqameen]

This is more than helpful, thank you!