Link border, title and footer for mini.files, mini.clue and mini.pick to float border, title, footer in mini.base16.

[231tr0n]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.base16

Question

Hi @echasnovski! Is there any chance border, title and footer groups for mini.files, mini.clue and mini.pick can get linked to float border, title and footer in mini.base16 since that feels more natural and right? If not, is there any reason behind not doing it this way. I was curious to know why was it done this way.

[echasnovski]

Can you please clarify what exactly is the issue here? I thought I understood at first, but I have doubts.

Do you mean that:

• MiniClueBorder, MiniFilesBorder, and MiniPickBorder link to NormalFloat and not FloatBorder? The original idea was for them to have the same background as the rest of their floating windows.

  'mini.base16' does not define all built-in groups and relies a lot on default links. The FloatBorder on Neovim<0.10 was linked to Normal instead of NormalFloat, so explicit linking to NormalFloat in those groups was necessary. Now - probably not so much.

• MiniClueTitle, both of MiniFilesTitle[Focused], and MiniPickBorderText define their own attributes and not link to FloatTitle? Because they intentionally provide different highlighting. In particular, with bold text.

[231tr0n]

MiniClueBorder, MiniFilesBorder, and MiniPickBorder link to NormalFloat and not FloatBorder? The original idea was for them to have the same background as the rest of their floating windows.

Yeah, I meant this. Border for mini.clue, mini.files and mini.pick not linking to float border.
Also the title and footer text for mini.clue, mini.files and mini.pick not linking to floattitle and/or floatfooter.

The original idea was for them to have the same background as the rest of their floating windows.

If this is the case then is it possible to set floatborder properly to match normal float and link float border everywhere to all border highlight groups? The reason for me asking this is that if I need to override float border color manually and set, I will also have to explictly set the border for mini.clue, mini.files and mini.pick as well. Also this list will go on as more plugins are added to mini.nvim which use float windows.

[echasnovski]

Yeah, I meant this. Border for mini.clue, mini.files and mini.pick not linking to float border.
Also the title and footer text for mini.clue, mini.files and mini.pick not linking to floattitle and/or floatfooter.

Both of these are already explained. The first one is probably reasonable to adjust now. I'll take a closer look.

The original idea was for them to have the same background as the rest of their floating windows.

If this is the case then is it possible to set floatborder properly to match normal float and link it everywhere?

Here is the answer:

'mini.base16' does not define all built-in groups and relies a lot on default links.

[echasnovski]

This should now be resolved on latest main. There is an explicit FloatBorder and all MiniXxxBorder groups now link to it.

The title/footer highlight groups I think is best to remain the same.

[231tr0n]

Hey @echasnovski! So the Float[Title/Border] looks like the below picture in minicyan. Basically, since no colors are set for background for Float[Title/Footer], they look very odd and don't blend at all with the float background. I know you already mentioned that it is best for them to remain the same, but can you just think about it one last time.

The only problem is the background color of Float[Title/Border]. Also, if you do come to a conclusion on changing it then just setting the background color for FloatTitle, then linking it to FloatFooter, MiniPickBorderText and MiniFilesTitle would make all the title groups more generic. The only exceptions would be MiniFilesTitleFocused, MiniClueTitle and MiniPickPrompt[Caret/Prefix] which can have the bold version of FloatTitle colors which will be explicitly defined as you mentioned.

Besides, I apologize for bringing this topic up many times even though I could just override the color schemes myself which I am currently doing, I just thought doing it this way would result in better experience and hence I am writing this.

[echasnovski]

So the Float[Title/Border] looks like the below picture in minicyan. Basically, since no colors are set for background for Float[Title/Footer], they look very odd and don't blend at all with the float background. I know you already mentioned that it is best for them to remain the same, but can you just think about it one last time.

That is an intentional look of 'mini.base16'. I don't have many plans to revisit and tweak it. Otherwise there are a lot of things I'd change and it would mostly become the 'mini.hues' (which is the primary color scheme focus of 'mini.nvim') :)

Besides, I apologize for bringing this topic up many times even though I could just override the color schemes myself which I am currently doing, I just thought doing it this way would result in better experience and hence I am writing this.

Thank you for caring 🙏