[mini.pick] Unable to override grep_live opts (match, add_glob)

[drowning-cat]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.pick

Question

force or keep?

mini.nvim/lua/mini/pick.lua

Line 1411 in 6f11e41

opts = vim.tbl_deep_extend('force', opts or {}, { source = { items = {}, match = match }, mappings = mappings })

[echasnovski]

Can you please elaborate on why do you think they should be overridable? What do you try to achieve here?

grep_live is a very special picker with a very special source.match.

<C-o> as a special picker mapping is documented and fixed.

[drowning-cat]

grep_live is a very special picker with a very special source.match.

Basically, I want to write a custom matcher specifically for the grep picker that will parse input like name | glob, glob, glob. Now, it seems more sensible to write the picker from scratch.

I thought it could be done like with the show field:

local minipick_grep_live_match = function(stritems, inds, query_tbl, opts)
  -- Modify `query_tbl`
  return MiniPick.default_match(stritems, inds, query_tbl, opts)
end

<C-o> as a special picker mapping

I wanted to disable or override it:

  MiniPick.builtin.grep_live({}, {
    mappings = {
      aa_override = {
        char = "<C-o>",
        func = function()
          -- Doesn't work
          vim.print("+")
        end,
      },
    },
  })

I needed to think a bit harder before asking. Maybe I can’t quite get used to multiple models of defining mappings.

[echasnovski]

I am afraid, grep_live is indeed a very special picker which is also quite fragile. I would like to avoid having to update and/or rewrite it to account for possible "hacking". It is indeed better to write custom picker to fully own the "live" part of the implementation.

I guess it can be done like this:

Probably, not 100% of the time. The <C-o> key might be associated either with add_glob or aa_override. There is no order guarantee of how actions are matched to their keys.

[drowning-cat]

You're right, it is a Lua hash map after all. Thank you for the answers, and sorry for the stupid questions.
I'll try to actually think before asking next time :)