Merge pull request #85 from obalunenko/fix-race

obalunenko · web-flow · commit 46f3727c0b2e · 2022-01-14T19:37:35.000+03:00
fix(2016/day01): Data race issue
diff --git a/internal/puzzles/solutions/2016/day01/solution.go b/internal/puzzles/solutions/2016/day01/solution.go
@@ -186,12 +186,14 @@ func (d direction) strikeTo(t turn) direction {
 }
 
 type cab struct {
+	mu     *sync.Mutex
 	curDir direction
 	n      navigator
 }
 
 func newCab() cab {
 	return cab{
+		mu:     &sync.Mutex{},
 		curDir: northDirection,
 		n:      newNavigator(),
 	}
@@ -204,6 +206,9 @@ const (
 )
 
 func (c *cab) Move(t turn, steps int) error {
+	c.mu.Lock()
+	defer c.mu.Unlock()
+
 	c.curDir = c.curDir.strikeTo(t)
 	if !c.curDir.isValid() {
 		return errInvalidDirect

Original file line number	Diff line number	Diff line change
`@@ -186,12 +186,14 @@ func (d direction) strikeTo(t turn) direction {`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`type cab struct {`
	`189`	`+ mu *sync.Mutex`
`189`	`190`	`curDir direction`
`190`	`191`	`n navigator`
`191`	`192`	`}`
`192`	`193`
`193`	`194`	`func newCab() cab {`
`194`	`195`	`return cab{`
	`196`	`+ mu: &sync.Mutex{},`
`195`	`197`	`curDir: northDirection,`
`196`	`198`	`n: newNavigator(),`
`197`	`199`	`}`
`@@ -204,6 +206,9 @@ const (`
`204`	`206`	`)`
`205`	`207`
`206`	`208`	`func (c *cab) Move(t turn, steps int) error {`
	`209`	`+ c.mu.Lock()`
	`210`	`+ defer c.mu.Unlock()`
	`211`	`+`
`207`	`212`	`c.curDir = c.curDir.strikeTo(t)`
`208`	`213`	`if !c.curDir.isValid() {`
`209`	`214`	`return errInvalidDirect`