Skip to content

Commit e782bed

Browse files
GitLab: update merge request template
1 parent 95977db commit e782bed

File tree

1 file changed

+17
-13
lines changed

1 file changed

+17
-13
lines changed
Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,27 @@
11
## What does this merge request do?
22

3-
Addresses objectbox/objectbox-swift#NUMBER+
3+
TODO Link associated issue from title, like: `<title> objectbox-swift#NUMBER`
44

5-
<!-- Briefly describe what this merge request is about. -->
5+
TODO Briefly list what this merge request is about
66

77
## Author's checklist
88

99
- [ ] This merge request fully addresses the requirements of the associated task
10-
- [ ] I did a self-review of the changes and did not spot any issues. Among others, this includes:
11-
* I added unit tests for new or changed behavior; all tests pass.
12-
* My code conforms to our coding standards and guidelines.
13-
* My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer.
14-
- [ ] I assigned a reviewer to request review.
10+
- [ ] I did a self-review of the changes and did not spot any issues, among others:
11+
- I added unit tests for new or changed behavior; existing and new tests pass
12+
- My code conforms to our coding standards and guidelines
13+
- My changes are prepared (focused commits, good messages) so reviewing them is easy for the reviewer
14+
- [ ] I amended the public changelog if this affects users in any way
15+
- [ ] I assigned a reviewer to request review
1516

16-
## Review checklist
17+
## Reviewer's checklist
1718

18-
- [ ] I reviewed all changes line-by-line and addressed relevant issues
19+
- [ ] I reviewed all changes line-by-line and addressed relevant issues. However:
20+
- for quickly resolved issues, I considered creating a fixup commit and discussing that, and
21+
- instead of many or long comments, I considered a meeting with or a draft commit for the author.
1922
- [ ] The requirements of the associated task are fully met
20-
- [ ] I can confirm that:
21-
* CI passes
22-
* New code conforms to standards and guidelines
23-
* If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses)
23+
- [ ] I can confirm that:
24+
- CI passes
25+
- If applicable, coverage percentages do not decrease
26+
- New code conforms to standards and guidelines
27+
- If applicable, additional checks were done for special code changes (e.g. core performance, binary size, OSS licenses)

0 commit comments

Comments
 (0)