Skip to content

Commit ec6d2fb

Browse files
authored
Merge pull request #1795 from xvw/fix-1794
Fix #1794: Add `-unboxed-types` and `-no-unboxed-types` to ignored flags
2 parents d5bc15a + 68c5d3c commit ec6d2fb

File tree

3 files changed

+18
-4
lines changed

3 files changed

+18
-4
lines changed

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ unreleased
44
+ merlin binary
55
- A new `WRAPPING_PREFIX` configuration directive that can be used to tell Merlin
66
what to append to the current unit name in the presence of wrapping (#1788)
7+
- Add `-unboxed-types` and `-no-unboxed-types` as ocaml ignored flags (#1795, fixes #1794)
78

89
merlin 5.1
910
==========

src/kernel/mconfig.ml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -457,10 +457,10 @@ let ocaml_ignored_flags = [
457457
"-noautolink"; "-no-check-prims"; "-nodynlink"; "-no-float-const-prop";
458458
"-no-keep-locs"; "-no-principal"; "-no-rectypes"; "-no-strict-formats";
459459
"-no-strict-sequence"; "-no-unbox-free-vars-of-clos";
460-
"-no-unbox-specialised-args"; "-O2"; "-O3"; "-Oclassic"; "-opaque";
461-
"-output-complete-obj"; "-output-obj"; "-p"; "-pack";
462-
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures"; "-v";
463-
"-verbose"; "-where";
460+
"-no-unbox-specialised-args"; "-no-unboxed-types"; "-O2"; "-O3";
461+
"-Oclassic"; "-opaque"; "-output-complete-obj"; "-output-obj"; "-p"; "-pack";
462+
"-remove-unused-arguments"; "-S"; "-shared"; "-unbox-closures";
463+
"-unboxed-types"; "-v"; "-verbose"; "-where";
464464
]
465465

466466
let ocaml_ignored_parametrized_flags = [

tests/test-dirs/errors/issue1794.t

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
$ $MERLIN single errors -filename main.ml -unboxed-types
2+
{
3+
"class": "return",
4+
"value": [],
5+
"notifications": []
6+
}
7+
8+
$ $MERLIN single errors -filename main.ml -no-unboxed-types
9+
{
10+
"class": "return",
11+
"value": [],
12+
"notifications": []
13+
}

0 commit comments

Comments
 (0)