[IMP] estate: validation, computed fields and onchanges in fields

Added buttons for offer status
Added buttons for Property status
Added action for those buttons
Demonstrated computed fields and onchanges fields
Raised UserError exceptions for particular conditions

Author: stan-odoo

estate/models/estate_property.py

@@ -1,7 +1,7 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
 from datetime import datetime, timedelta
-from odoo import models, fields
+from odoo import api, models, fields, exceptions
 
 
 class EstateProperty(models.Model):
@@ -37,13 +37,52 @@ class EstateProperty(models.Model):
         required=True,
         selection=[
             ('new', 'New'),
-            ('offer_recieved', 'Offer Received'),
+            ('offer_received', 'Offer Received'),
             ('offer_accepted', 'Offer Accepted'),
-            ('sold_and_cancelled', 'Sold and Cancelled')
+            ('sold', 'Sold'),
+            ('cancel', 'Cancelled')
         ],
         help='State of the property')
     property_type_id = fields.Many2one('estate.property.type', string='Property Type Id')
-    buyer_id = fields.Many2one('res.users', string='Buyer', copy=False)
-    salesman_id = fields.Many2one('res.partner', string='Salesman', default=lambda self: self.env.user)
+    buyer_id = fields.Many2one('res.partner', string='Buyer', copy=False)
+    salesman_id = fields.Many2one('res.users', string='Salesman', default=lambda self: self.env.user)
     tag_ids = fields.Many2many('estate.property.tag', string='Estate property Tag')
     offer_ids = fields.One2many('estate.property.offer', 'property_id', string='offer')
+    total_area = fields.Float(compute="_compute_total_area")
+    best_price = fields.Float(compute='_compute_best_price', string='Best Offer Price')
+
+    @api.depends('living_area', 'garden_area')
+    def _compute_total_area(self):
+        for record in self:
+            record.total_area = record.garden_area + record.living_area
+
+    @api.depends('offer_ids.price')
+    def _compute_best_price(self):
+        for record in self:
+            record.best_price = max(record.offer_ids.mapped('price'), default=0.0)
+
+    @api.onchange('garden')
+    def _on_change_garden(self):
+        for record in self:
+            if self.garden:
+                record.garden_area = 10
+                record.garden_orientation = 'north'
+            else:
+                record.garden_area = False
+                record.garden_orientation = False
+
+    def property_sold_action(self):
+        for record in self:
+            if record.state == 'cancel':
+                raise exceptions.UserError('Cancelled property can not be sold')
+            else:
+                record.state = 'sold'
+        return True
+
+    def property_cancel_action(self):
+        for record in self:
+            if record.state == 'sold':
+                raise exceptions.UserError('Sold property can not be cancelled')
+            else:
+                record.state = 'cancel'
+        return True

estate/models/estate_property_offer.py

@@ -1,6 +1,7 @@
 # Part of Odoo. See LICENSE file for full copyright and licensing details.
 
-from odoo import fields, models
+from datetime import timedelta
+from odoo import api, fields, models
 
 
 class EstatePropertyOffer(models.Model):
@@ -9,11 +10,41 @@ class EstatePropertyOffer(models.Model):
 
     price = fields.Float(string='Offer Price')
     status = fields.Selection(
-        string='Status Of Offer',
+        string='Status',
         copy=False,
         selection=[
             ('accepted', 'Accepted'),
             ('refused', 'Refused')
         ])
     partner_id = fields.Many2one('res.partner', required=True)
     property_id = fields.Many2one('estate.property', required=True)
+    created_date = fields.Date(default=fields.Date.context_today, string="Created Date")
+    validity = fields.Integer(default=7, string="Validity (Days)")
+    date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline", string="Deadline Date", store="True")
+
+    @api.depends('created_date', 'validity')
+    def _compute_date_deadline(self):
+        for record in self:
+            if record.created_date and record.validity:
+                record.date_deadline = record.created_date + timedelta(days=record.validity)
+            else:
+                record.date_deadline = False
+
+    def _inverse_date_deadline(self):
+        for record in self:
+            if record.date_deadline and record.created_date:
+                record.validity = (record.date_deadline - record.created_date).days
+            else:
+                record.validity = 0
+
+    def offer_accepted_action(self):
+        for record in self:
+            record.status = 'accepted'
+            record.property_id.buyer_id = record.partner_id
+            record.property_id.selling_price = record.price
+        return True
+
+    def offer_refused_action(self):
+        for record in self:
+            record.status = 'refused'
+        return True

estate/views/estate_property_offer_views.xml

@@ -7,13 +7,17 @@
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <list>
-                <field name="price" />
-                <field name="partner_id" />
+                <field name="price" string="Price" />
+                <field name="partner_id" string="Partner" />
+                <field name="validity" string="Validity (days)" />
+                <field name="date_deadline" string="Deadline" />
+                <button string="" name="offer_accepted_action" type="object" icon="fa-check"/>
+                <button string="" name="offer_refused_action" type="object" icon="fa-times"/>
                 <field name="status" />
             </list>
         </field>
     </record>
-
+    
     <!-- Form View -->
     <record id="estate_property_offer_view_form" model="ir.ui.view">
         <field name="name">estate.property.offer.form</field>
@@ -22,13 +26,16 @@
             <form string="Offer Price Form">
                 <sheet>
                     <group>
-                        <field name="price" string="Offer Price" />
+                        <field name="price" string="Price" />
                         <field name="status" string="Offer Status" />
-                        <field name="partner_id" string="Offer Partner" />
+                        <field name="partner_id" string="Partner" />
+                        <field name="validity" string="Validity (days) " />
+                        <field name="date_deadline" string="Deadline" />
+                        <field name="status" />
                     </group>
                 </sheet>
             </form>
         </field>
     </record>
 
-</odoo>
+</odoo>

estate/views/estate_property_views.xml

@@ -33,6 +33,10 @@
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <form string="Estate Property Form">
+                <header>
+                    <button string="Cancel" name="property_cancel_action" type="object" class="oe_highlight"/>
+                    <button string="Sold" name="property_sold_action" type="object" class="oe_highlight"/>
+                </header>
                 <sheet>
                     <div>
                         <h1>
@@ -41,15 +45,18 @@
                         </h1>
                         <field name="tag_ids" string="Property Tags" widget="many2many_tags" />
                     </div>
+                    <br />
                     <group>
                         <group>
+                            <field name="state" string="State"/>
                             <field name="property_type_id" string="Property Type" />
                             <field name="postcode" string="Postcode" />
                             <field name="date_availability" string="Available from" />
                         </group>
                         <group>
                             <field name="expected_price" string="Expected Price" />
                             <field name="selling_price" string="Selling Price" />
+                            <field name="best_price" string="Best Price" />
                         </group>
                     </group>
                     <notebook>
@@ -64,6 +71,7 @@
                                 <field name="garden_area" string="Garden Area (sqm)" />
                                 <field name="garden_orientation" string="Garden orientation" />
                                 <field name="state" string="Current state" />
+                                <field name="total_area" string="Total Area (sqm)" />
                             </group>
                         </page>
                         <page string="Offers">
@@ -72,8 +80,8 @@
                         </page>
                         <page string="Page Info">
                             <group>
-                                <field name="buyer_id" string="Buyer" />
                                 <field name="salesman_id" string="Salesman" />
+                                <field name="buyer_id" string="Buyer" />
                             </group>
                         </page>
                     </notebook>
@@ -96,7 +104,7 @@
                 <field name="facades" string="Facades" />
                 <separator />
                 <filter string="Available" name="state"
-                    domain="[('state', 'in', ['new', 'offer_recieved'])]" />
+                    domain="[('state', 'in', ['new', 'offer_received'])]" />
                 <filter name="postcode" string="Postcode" context="{'group_by': 'postcode'}" />
             </search>
         </field>