[IMP] estate: applied some coding guidelines to model names and views

Author: yagho-odoo

estate/models/estate_property.py

@@ -57,15 +57,6 @@ def _compute_best_offer(self):
             prices = property.offer_ids.mapped('price')
             property.best_offer = max(prices, default=0.0)
 
-    @api.onchange('garden')
-    def _onchange_garden(self):
-        if (self.garden):
-            self.garden_area = 10
-            self.garden_orientation = 'North'
-        else:
-            self.garden_area = 0
-            self.garden_orientation = ''
-
     def action_sold(self):
         if (self.state != "Cancelled"):
             self.state = "Sold"
@@ -80,6 +71,15 @@ def action_cancel(self):
             raise UserError("A sold property can not be cancelled")
         return True
 
+    @api.onchange('garden')
+    def _onchange_garden(self):
+        if (self.garden):
+            self.garden_area = 10
+            self.garden_orientation = 'North'
+        else:
+            self.garden_area = 0
+            self.garden_orientation = ''
+
     @api.ondelete(at_uninstall=False)
     def _unlink_property(self):
         for property in self:

estate/models/estate_property_offer.py

@@ -14,7 +14,8 @@ class EstatePropertyOffer(models.Model):
     status = fields.Selection(
         string='status',
         selection=[('Accepted', 'Accepted'), ('Refused', 'Refused')],
-        copy=False)
+        copy=False
+    )
     validity = fields.Integer(default=7)
     date_deadline = fields.Date(compute="_compute_date_deadline", inverse="_inverse_date_deadline")
     partner_id = fields.Many2one("res.partner", string="partner", required=True)
@@ -60,13 +61,13 @@ def _check_price_validity(self):
     @api.model_create_multi
     def create(self, vals_list):
         property_ids = [property['property_id'] for property in vals_list]
-        property_objs = self.env['estate.property'].browse(property_ids)
-        for property_obj in property_objs:
-            if (property_obj.offer_ids):
-                curr_lowest_offer = min(property_obj.offer_ids.mapped('price'))
+        Properties = self.env['estate.property'].browse(property_ids)
+        for Property in Properties:
+            if (Property.offer_ids):
+                curr_lowest_offer = min(Property.offer_ids.mapped('price'))
                 if float_compare(vals_list[0]['price'], curr_lowest_offer, 2) < 0:
                     raise ValidationError("Offered price must be higher than already existing offers")
 
-            if not property_obj.offer_ids:
-                property_obj.state = 'Offer Received'
+            if not Property.offer_ids:
+                Property.state = 'Offer Received'
         return super().create(vals_list)

estate/models/res_users_child.py

@@ -1,7 +1,7 @@
 from odoo import fields, models
 
 
-class resUsersChild(models.Model):
+class ResUsersChild(models.Model):
     _inherit = 'res.users'
 
     property_ids = fields.One2many('estate.property', 'salesperson_id', string="sales person", domain="[('state', 'in', ['New', 'Offer Received'])]")

estate/views/estate_property_menu_views.xml

@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <menuitem id="test_menu_root" name="Estate">
-        <menuitem id="test_first_level_menu" name="ADs">
+    <menuitem id="estate_property_menu_root" name="Estate">
+        <menuitem id="estate_property_menu_properties" name="ADs">
             <menuitem id="estate_property_menu_action" action="estate_property_action"/>
         </menuitem>
-        <menuitem id="test_first_level_menu2" name="Settings">
-            <menuitem id="estate_property_menu_action_3" action="estate_property_type_action"/>
+        <menuitem id="estate_property_menu_settings" name="Settings">
+            <menuitem id="estate_property_type_menu_action" action="estate_property_type_action"/>
             <menuitem id="estate_property_tag_menu_action" action="estate_property_tag_action"/>
         </menuitem>
     </menuitem>

estate/views/estate_property_views.xml

@@ -8,7 +8,7 @@
             <field name="context">{'search_default_state': True}</field>
         </record>
 
-        <record id="estate_property_new_view_search" model="ir.ui.view">
+        <record id="estate_property_view_search" model="ir.ui.view">
             <field name="name">estate.property.view.search</field>
             <field name="model">estate.property</field>
             <field name="arch" type="xml">
@@ -28,7 +28,7 @@
         </record>
 
         <record id="estate_property_view_list" model="ir.ui.view">
-            <field name="name">estate.property.list</field>
+            <field name="name">estate.property.view.list</field>
             <field name="model">estate.property</field>
             <field name="arch" type="xml">
                 <list string="Channel" decoration-success="state in ['Offer Received', 'Offer Accepted']" decoration-bf="state in ['Offer Accepted']" decoration-muted="state in ['Sold']">
@@ -46,7 +46,7 @@
         </record>
 
         <record id="estate_property_view_form" model="ir.ui.view">
-            <field name="name">estate.property.form</field>
+            <field name="name">estate.property.view.form</field>
             <field name="model">estate.property</field>
             <field name="arch" type="xml">
                 <form string="Test">
@@ -103,7 +103,7 @@
         </record>
 
         <record id="estate_property_view_kanban" model="ir.ui.view">
-            <field name="name">estate.property.kanban</field>
+            <field name="name">estate.property.view.kanban</field>
             <field name="model">estate.property</field>
             <field name="arch" type="xml">
                 <kanban default_group_by="type_id" records_draggable="false">

estate/views/res_users_child_views.xml

@@ -2,7 +2,7 @@
 <odoo>
     <data>
         <record id="res_users_view_form" model="ir.ui.view">
-            <field name="name">res.users.view.form.inherit.form</field>
+            <field name="name">res.users.view.form.inherit.res.users.child</field>
             <field name="model">res.users</field>
             <field name="inherit_id" ref="base.view_users_form"/>
             <field name="arch" type="xml">

estate_account/models/estate_property_child.py

@@ -2,7 +2,7 @@
 from odoo.exceptions import UserError
 
 
-class estatePropertyChild(models.Model):
+class EstatePropertyChild(models.Model):
     _inherit = 'estate.property'
 
     def _get_default_journal(self):