Prefer double-quoted strings

Author: sferik

.rubocop.yml

@@ -7,7 +7,7 @@ Metrics/LineLength:
 
 Metrics/MethodLength:
   CountComments: false
-  Max: 15
+  Max: 10
 
 Metrics/ParameterLists:
   Max: 4
@@ -26,29 +26,17 @@ Style/CollectionMethods:
 Style/Documentation:
   Enabled: false
 
-Style/DotPosition:
-  EnforcedStyle: trailing
-
 Style/DoubleNegation:
   Enabled: false
 
-Style/EachWithObject:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
 Style/HashSyntax:
   EnforcedStyle: hash_rockets
 
-Style/Lambda:
-  Enabled: false
-
-Style/RaiseArgs:
-  EnforcedStyle: compact
-
 Style/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
 Style/TrailingComma:
   EnforcedStyleForMultiline: 'comma'

Gemfile

@@ -1,17 +1,17 @@
-source 'http://rubygems.org'
+source "http://rubygems.org"
 
-gem 'rake'
+gem "rake"
 
 group :test do
-  gem 'coveralls'
-  gem 'json', :platforms => [:jruby, :ruby_18, :ruby_19]
-  gem 'mime-types', '~> 1.25', :platforms => [:jruby, :ruby_18]
-  gem 'rack-test'
-  gem 'rest-client', '~> 1.6.0', :platforms => [:jruby, :ruby_18]
-  gem 'rspec', '~> 3.2'
-  gem 'rubocop', '>= 0.30', :platforms => [:ruby_19, :ruby_20, :ruby_21, :ruby_22]
-  gem 'simplecov', '>= 0.9'
-  gem 'webmock'
+  gem "coveralls"
+  gem "json", :platforms => [:jruby, :ruby_18, :ruby_19]
+  gem "mime-types", "~> 1.25", :platforms => [:jruby, :ruby_18]
+  gem "rack-test"
+  gem "rest-client", "~> 1.6.0", :platforms => [:jruby, :ruby_18]
+  gem "rspec", "~> 3.2"
+  gem "rubocop", ">= 0.30", :platforms => [:ruby_19, :ruby_20, :ruby_21, :ruby_22]
+  gem "simplecov", ">= 0.9"
+  gem "webmock"
 end
 
 # Specify your gem's dependencies in omniauth-oauth2.gemspec

Rakefile

@@ -1,17 +1,17 @@
 #!/usr/bin/env rake
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new
 
 task :test => :spec
 
 begin
-  require 'rubocop/rake_task'
+  require "rubocop/rake_task"
   RuboCop::RakeTask.new
 rescue LoadError
   task :rubocop do
-    $stderr.puts 'RuboCop is disabled'
+    $stderr.puts "RuboCop is disabled"
   end
 end
 

lib/omniauth-oauth2.rb

@@ -1,2 +1,2 @@
-require 'omniauth-oauth2/version' # rubocop:disable FileName
-require 'omniauth/strategies/oauth2'
+require "omniauth-oauth2/version" # rubocop:disable FileName
+require "omniauth/strategies/oauth2"

lib/omniauth-oauth2/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module OAuth2
-    VERSION = '1.2.0'
+    VERSION = "1.2.0"
   end
 end

lib/omniauth/strategies/oauth2.rb

@@ -1,8 +1,8 @@
-require 'oauth2'
-require 'omniauth'
-require 'securerandom'
-require 'socket'       # for SocketError
-require 'timeout'      # for Timeout::Error
+require "oauth2"
+require "omniauth"
+require "securerandom"
+require "socket"       # for SocketError
+require "timeout"      # for Timeout::Error
 
 module OmniAuth
   module Strategies
@@ -37,10 +37,10 @@ def callback_url
       end
 
       credentials do
-        hash = {'token' => access_token.token}
-        hash.merge!('refresh_token' => access_token.refresh_token) if access_token.expires? && access_token.refresh_token
-        hash.merge!('expires_at' => access_token.expires_at) if access_token.expires?
-        hash.merge!('expires' => access_token.expires?)
+        hash = {"token" => access_token.token}
+        hash.merge!("refresh_token" => access_token.refresh_token) if access_token.expires? && access_token.refresh_token
+        hash.merge!("expires_at" => access_token.expires_at) if access_token.expires?
+        hash.merge!("expires" => access_token.expires?)
         hash
       end
 
@@ -50,25 +50,25 @@ def request_phase
 
       def authorize_params
         options.authorize_params[:state] = SecureRandom.hex(24)
-        params = options.authorize_params.merge(options_for('authorize'))
+        params = options.authorize_params.merge(options_for("authorize"))
         if OmniAuth.config.test_mode
           @env ||= {}
-          @env['rack.session'] ||= {}
+          @env["rack.session"] ||= {}
         end
-        session['omniauth.state'] = params[:state]
+        session["omniauth.state"] = params[:state]
         params
       end
 
       def token_params
-        options.token_params.merge(options_for('token'))
+        options.token_params.merge(options_for("token"))
       end
 
       def callback_phase # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength, PerceivedComplexity
-        error = request.params['error_reason'] || request.params['error']
+        error = request.params["error_reason"] || request.params["error"]
         if error
-          fail!(error, CallbackError.new(request.params['error'], request.params['error_description'] || request.params['error_reason'], request.params['error_uri']))
-        elsif !options.provider_ignores_state && (request.params['state'].to_s.empty? || request.params['state'] != session.delete('omniauth.state'))
-          fail!(:csrf_detected, CallbackError.new(:csrf_detected, 'CSRF detected'))
+          fail!(error, CallbackError.new(request.params["error"], request.params["error_description"] || request.params["error_reason"], request.params["error_uri"]))
+        elsif !options.provider_ignores_state && (request.params["state"].to_s.empty? || request.params["state"] != session.delete("omniauth.state"))
+          fail!(:csrf_detected, CallbackError.new(:csrf_detected, "CSRF detected"))
         else
           self.access_token = build_access_token
           self.access_token = access_token.refresh! if access_token.expired?
@@ -85,7 +85,7 @@ def callback_phase # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength
     protected
 
       def build_access_token
-        verifier = request.params['code']
+        verifier = request.params["code"]
         client.auth_code.get_token(verifier, {:redirect_uri => callback_url}.merge(token_params.to_hash(:symbolize_keys => true)), deep_symbolize(options.auth_token_params))
       end
 
@@ -117,11 +117,11 @@ def initialize(error, error_reason = nil, error_uri = nil)
         end
 
         def message
-          [error, error_reason, error_uri].compact.join(' | ')
+          [error, error_reason, error_uri].compact.join(" | ")
         end
       end
     end
   end
 end
 
-OmniAuth.config.add_camelization 'oauth2', 'OAuth2'
+OmniAuth.config.add_camelization "oauth2", "OAuth2"

omniauth-oauth2.gemspec

@@ -1,24 +1,24 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'omniauth-oauth2/version'
+require "omniauth-oauth2/version"
 
 Gem::Specification.new do |gem|
-  gem.add_dependency 'oauth2',     '~> 1.0'
-  gem.add_dependency 'omniauth',   '~> 1.2'
+  gem.add_dependency "oauth2",     "~> 1.0"
+  gem.add_dependency "omniauth",   "~> 1.2"
 
-  gem.add_development_dependency 'bundler', '~> 1.0'
+  gem.add_development_dependency "bundler", "~> 1.0"
 
-  gem.authors       = ['Michael Bleigh', 'Erik Michaels-Ober']
-  gem.email         = ['[email protected]', '[email protected]']
-  gem.description   = 'An abstract OAuth2 strategy for OmniAuth.'
+  gem.authors       = ["Michael Bleigh", "Erik Michaels-Ober"]
+  gem.email         = ["[email protected]", "[email protected]"]
+  gem.description   = "An abstract OAuth2 strategy for OmniAuth."
   gem.summary       = gem.description
-  gem.homepage      = 'https://github.com/intridea/omniauth-oauth2'
+  gem.homepage      = "https://github.com/intridea/omniauth-oauth2"
   gem.licenses      = %w(MIT)
 
   gem.executables   = `git ls-files -- bin/*`.split("\n").collect { |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  gem.name          = 'omniauth-oauth2'
+  gem.name          = "omniauth-oauth2"
   gem.require_paths = %w(lib)
   gem.version       = OmniAuth::OAuth2::VERSION
 end

spec/helper.rb

@@ -1,9 +1,9 @@
-$LOAD_PATH.unshift File.expand_path('..', __FILE__)
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path("..", __FILE__)
+$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
 
-if RUBY_VERSION >= '1.9'
-  require 'simplecov'
-  require 'coveralls'
+if RUBY_VERSION >= "1.9"
+  require "simplecov"
+  require "coveralls"
 
   SimpleCov.formatters = [SimpleCov::Formatter::HTMLFormatter, Coveralls::SimpleCov::Formatter]
 
@@ -12,11 +12,11 @@
   end
 end
 
-require 'rspec'
-require 'rack/test'
-require 'webmock/rspec'
-require 'omniauth'
-require 'omniauth-oauth2'
+require "rspec"
+require "rack/test"
+require "webmock/rspec"
+require "omniauth"
+require "omniauth-oauth2"
 
 RSpec.configure do |config|
   config.expect_with :rspec do |c|

spec/omniauth/strategies/oauth2_spec.rb

@@ -1,9 +1,9 @@
-require 'helper'
+require "helper"
 
 describe OmniAuth::Strategies::OAuth2 do
   def app
     lambda do |_env|
-      [200, {}, ['Hello.']]
+      [200, {}, ["Hello."]]
     end
   end
   let(:fresh_strategy) { Class.new(OmniAuth::Strategies::OAuth2) }
@@ -16,83 +16,83 @@ def app
     OmniAuth.config.test_mode = false
   end
 
-  describe '#client' do
+  describe "#client" do
     subject { fresh_strategy }
 
-    it 'is initialized with symbolized client_options' do
-      instance = subject.new(app, :client_options => {'authorize_url' => 'https://example.com'})
-      expect(instance.client.options[:authorize_url]).to eq('https://example.com')
+    it "is initialized with symbolized client_options" do
+      instance = subject.new(app, :client_options => {"authorize_url" => "https://example.com"})
+      expect(instance.client.options[:authorize_url]).to eq("https://example.com")
     end
 
-    it 'sets ssl options as connection options' do
-      instance = subject.new(app, :client_options => {'ssl' => {'ca_path' => 'foo'}})
-      expect(instance.client.options[:connection_opts][:ssl]).to eq(:ca_path => 'foo')
+    it "sets ssl options as connection options" do
+      instance = subject.new(app, :client_options => {"ssl" => {"ca_path" => "foo"}})
+      expect(instance.client.options[:connection_opts][:ssl]).to eq(:ca_path => "foo")
     end
   end
 
-  describe '#authorize_params' do
+  describe "#authorize_params" do
     subject { fresh_strategy }
 
-    it 'includes any authorize params passed in the :authorize_params option' do
-      instance = subject.new('abc', 'def', :authorize_params => {:foo => 'bar', :baz => 'zip'})
-      expect(instance.authorize_params['foo']).to eq('bar')
-      expect(instance.authorize_params['baz']).to eq('zip')
+    it "includes any authorize params passed in the :authorize_params option" do
+      instance = subject.new("abc", "def", :authorize_params => {:foo => "bar", :baz => "zip"})
+      expect(instance.authorize_params["foo"]).to eq("bar")
+      expect(instance.authorize_params["baz"]).to eq("zip")
     end
 
-    it 'includes top-level options that are marked as :authorize_options' do
-      instance = subject.new('abc', 'def', :authorize_options => [:scope, :foo, :state], :scope => 'bar', :foo => 'baz')
-      expect(instance.authorize_params['scope']).to eq('bar')
-      expect(instance.authorize_params['foo']).to eq('baz')
+    it "includes top-level options that are marked as :authorize_options" do
+      instance = subject.new("abc", "def", :authorize_options => [:scope, :foo, :state], :scope => "bar", :foo => "baz")
+      expect(instance.authorize_params["scope"]).to eq("bar")
+      expect(instance.authorize_params["foo"]).to eq("baz")
     end
 
-    it 'includes random state in the authorize params' do
-      instance = subject.new('abc', 'def')
-      expect(instance.authorize_params.keys).to eq(['state'])
-      expect(instance.session['omniauth.state']).not_to be_empty
+    it "includes random state in the authorize params" do
+      instance = subject.new("abc", "def")
+      expect(instance.authorize_params.keys).to eq(["state"])
+      expect(instance.session["omniauth.state"]).not_to be_empty
     end
   end
 
-  describe '#token_params' do
+  describe "#token_params" do
     subject { fresh_strategy }
 
-    it 'includes any authorize params passed in the :authorize_params option' do
-      instance = subject.new('abc', 'def', :token_params => {:foo => 'bar', :baz => 'zip'})
-      expect(instance.token_params).to eq('foo' => 'bar', 'baz' => 'zip')
+    it "includes any authorize params passed in the :authorize_params option" do
+      instance = subject.new("abc", "def", :token_params => {:foo => "bar", :baz => "zip"})
+      expect(instance.token_params).to eq("foo" => "bar", "baz" => "zip")
     end
 
-    it 'includes top-level options that are marked as :authorize_options' do
-      instance = subject.new('abc', 'def', :token_options => [:scope, :foo], :scope => 'bar', :foo => 'baz')
-      expect(instance.token_params).to eq('scope' => 'bar', 'foo' => 'baz')
+    it "includes top-level options that are marked as :authorize_options" do
+      instance = subject.new("abc", "def", :token_options => [:scope, :foo], :scope => "bar", :foo => "baz")
+      expect(instance.token_params).to eq("scope" => "bar", "foo" => "baz")
     end
   end
 
-  describe '#callback_phase' do
+  describe "#callback_phase" do
     subject { fresh_strategy }
-    it 'calls fail with the client error received' do
-      instance = subject.new('abc', 'def')
+    it "calls fail with the client error received" do
+      instance = subject.new("abc", "def")
       allow(instance).to receive(:request) do
-        double('Request', :params => {'error_reason' => 'user_denied', 'error' => 'access_denied'})
+        double("Request", :params => {"error_reason" => "user_denied", "error" => "access_denied"})
       end
 
-      expect(instance).to receive(:fail!).with('user_denied', anything)
+      expect(instance).to receive(:fail!).with("user_denied", anything)
       instance.callback_phase
     end
   end
 end
 
 describe OmniAuth::Strategies::OAuth2::CallbackError do
   let(:error) { Class.new(OmniAuth::Strategies::OAuth2::CallbackError) }
-  describe '#message' do
+  describe "#message" do
     subject { error }
-    it 'includes all of the attributes' do
-      instance = subject.new('error', 'description', 'uri')
+    it "includes all of the attributes" do
+      instance = subject.new("error", "description", "uri")
       expect(instance.message).to match(/error/)
       expect(instance.message).to match(/description/)
       expect(instance.message).to match(/uri/)
     end
-    it 'includes all of the attributes' do
+    it "includes all of the attributes" do
       instance = subject.new(nil, :symbol)
-      expect(instance.message).to eq('symbol')
+      expect(instance.message).to eq("symbol")
     end
   end
 end