fix: batch job failure handling (and rollback), batch job end stats

Author: tomastrajan

lib/batch/tasks/finalize-job.task.ts

@@ -19,9 +19,10 @@ export function finalizeJobTaskFactory(
       process.chdir('../../');
 
       // update batch state
+      ctx.batch.completed.push(job);
+      ctx.batch.queue = ctx.batch.queue.filter((j) => j !== job);
+
       if (!ctx.options.preserveQueue) {
-        ctx.batch.completed.push(job);
-        ctx.batch.queue = ctx.batch.queue.filter((j) => j !== job);
         writeJson(ctx.options.jobPath, ctx.batch);
       }
 

lib/batch/tasks/run-job.task.ts

@@ -22,13 +22,13 @@ export function runJobTaskFactory(
     title: `${index} / ${total} - ${getRepoNameFromUrl(job)}`,
     rollback: async (ctx: Context, task) => {
       // update batch state
+      task.title = `${task.title} failed`;
+      ctx.batch.failed.push(job);
+      ctx.batch.queue = ctx.batch.queue.filter((j) => j !== job);
+
       if (!ctx.options.preserveQueue) {
-        ctx.batch.failed.push(job);
-        ctx.batch.queue = ctx.batch.queue.filter((j) => j !== job);
         writeJson(ctx.options.jobPath, ctx.batch);
         task.title = `${task.title} failed, added to failed jobs`;
-      } else {
-        task.title = `${task.title} failed`;
       }
     },
     task: async (ctx: Context, task) => {
@@ -43,6 +43,7 @@ export function runJobTaskFactory(
           finalizeJobTaskFactory(job, task),
         ],
         {
+          exitOnError: true,
           rendererOptions: {
             collapse: true,
           },

lib/utils/process.ts

@@ -36,9 +36,18 @@ export const runner = async (
       : 'default',
   })
     .run(context)
-    .then(() => {
+    .then((ctx: Context) => {
       const duration = new Date().getTime() - start;
       logger.info(`Finished (${formatTime(duration)})`);
+      const { batch } = ctx;
+      if (batch.completed.length || batch.failed.length) {
+        logger.info(
+          `Batch results, queue: ${batch.queue.length}, completed: ${batch.completed.length}, failed: ${batch.failed.length}`
+        );
+        batch.failed.forEach((project, index) => {
+          logger.error(`[FAILED] ${project}`);
+        });
+      }
       process.exit(0);
     })
     .catch((err) => {