FEATURE: Transaction scheduling #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

joshuahannan merged 97 commits into master from feature/callback-scheduling

Sep 15, 2025

Member

joshuahannan commented Jul 9, 2025 •

edited

Loading

Implements the contracts and tests for the Scheduled Callbacks FLIP

devbugging and others added 29 commits

July 2, 2025 11:25


          add safe scheduler contract

3df0e1d


          adding tests for estimate

6dd02f7


          remove some tests

618c07b


          fix test issues

352c6c6


          add estiamted callback error

a31805e


          update tests to check estiamte error

2e141a4


          prune statuses

dce16ac


          add todo

a3462c9


          add schedule tests

556e3bb


          clean up test

3b38e5c


          pr review feedback

b352a51


          todo tests

8fc371f


          address other PR comments

fd9db06


          fix priority enum, add fees deposit, and revert pre-conditions change

ab6b82d


          make ci

a6db6b4


          rearrange error messages in estimate and update tests

8c87d0a


          change EstimatedCallback to non-optional

81c74f4


          move transaction and update test

e343b96


          more schedule tests and scripts

898a583


          revert setStatus

8bff865


          update error handling for low priority callbacks

7ba2096


          add comments and update status constants in tests

49b3a1d


          add first draft of go package for callback scheduling

b8e2fce


          update pkg versions so tests pass

d4a3e56


          add schedule utility function

171a103


          add support for adding low priority callbacks to slots during processing

763b332


          add additional event arguments

b17ac2e


          fix timestamp and slotqueue naming

274a4fe


          Merge branch 'master' into feature/callback-scheduling

cf59ea0

joshuahannan requested a review from sisyphusSmiling

July 24, 2025 14:22

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

contracts/FlowTransactionScheduler.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

tests/transactionScheduler_events_test.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

tests/transactionScheduler_events_test.cdc

+                  let canceledEvent = canceledEvents[0] as! FlowTransactionScheduler.Canceled
+                  Test.assertEqual(transactionToCancel, canceledEvent.id)
+                  Test.assertEqual(mediumPriority, canceledEvent.priority)
+                  Test.assertEqual(feeAmount/UFix64(2.0), canceledEvent.feesReturned)

Collaborator

devbugging Sep 15, 2025

Might be smart to extract this into refundFeeRatio or something, since we use it a lot.

Collaborator

devbugging Sep 15, 2025

Also it might be smart to not set the refund multiplier in tests to 0.5 since then you don't have a way to assert correctness of feesReturned vs feesDeducted since they are both same. Not critical but maybe a todo.

devbugging reviewed

View reviewed changes

tests/transactionScheduler_events_test.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

tests/transactionScheduler_events_test.cdc Outdated Show resolved Hide resolved

devbugging reviewed

View reviewed changes

tests/transactionScheduler_misc_test.cdc Show resolved Hide resolved

devbugging reviewed

View reviewed changes

tests/transactionScheduler_misc_test.cdc Show resolved Hide resolved

devbugging approved these changes

View reviewed changes

Collaborator

devbugging left a comment

This is HUGE 🎉 great work!

joshuahannan added 2 commits

September 15, 2025 12:08


          address PR comments

b24c97b


          fix some tests

08fa8de

joshuahannan mentioned this pull request

Scheduled Txs: Update FlowTransactionScheduler tests to be less flaky #528

Open

joshuahannan merged commit d1ceee1 into master

2 of 4 checks passed

Member Author

joshuahannan commented Sep 15, 2025

Merged to master! Testnet here we come!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

janezpodhostnik janezpodhostnik left review comments

devbugging devbugging approved these changes

sisyphusSmiling sisyphusSmiling approved these changes

+3 more reviewers

bjartek bjartek left review comments

oebeling oebeling left review comments

bluesign bluesign left review comments

Labels

None yet