Skip to content

Commit 9987185

Browse files
author
Bernd Warmuth
committed
fixup! feat: implemented support for tracking
Signed-off-by: Bernd Warmuth <[email protected]>
1 parent 8568ca3 commit 9987185

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/main/java/dev/openfeature/sdk/OpenFeatureClient.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public ProviderState getProviderState() {
8181
*/
8282
@Override
8383
public void track(String trackingEventName) {
84-
Objects.requireNonNull(trackingEventName);
84+
validateTrackingEventName(trackingEventName);
8585
invokeTrack(trackingEventName, null, null);
8686
}
8787

@@ -91,7 +91,7 @@ public void track(String trackingEventName) {
9191
*/
9292
@Override
9393
public void track(String trackingEventName, EvaluationContext context) {
94-
Objects.requireNonNull(trackingEventName);
94+
validateTrackingEventName(trackingEventName);
9595
Objects.requireNonNull(context);
9696
invokeTrack(trackingEventName, context, null);
9797
}
@@ -101,7 +101,7 @@ public void track(String trackingEventName, EvaluationContext context) {
101101
*/
102102
@Override
103103
public void track(String trackingEventName, TrackingEventDetails details) {
104-
Objects.requireNonNull(trackingEventName);
104+
validateTrackingEventName(trackingEventName);
105105
Objects.requireNonNull(details);
106106
invokeTrack(trackingEventName, null, details);
107107
}
@@ -111,7 +111,7 @@ public void track(String trackingEventName, TrackingEventDetails details) {
111111
*/
112112
@Override
113113
public void track(String trackingEventName, EvaluationContext context, TrackingEventDetails details) {
114-
Objects.requireNonNull(trackingEventName);
114+
validateTrackingEventName(trackingEventName);
115115
Objects.requireNonNull(context);
116116
Objects.requireNonNull(details);
117117
invokeTrack(trackingEventName, mergeEvaluationContext(context), details);
@@ -229,10 +229,14 @@ private static <T> void enrichDetailsWithErrorDefaults(T defaultValue, FlagEvalu
229229
details.setReason(Reason.ERROR.toString());
230230
}
231231

232-
private void invokeTrack(String trackingEventName, EvaluationContext context, TrackingEventDetails details) {
233-
if ("".equals(trackingEventName)) {
232+
private static void validateTrackingEventName(String str) {
233+
Objects.requireNonNull(str);
234+
if (str.isEmpty()) {
234235
throw new IllegalArgumentException("trackingEventName cannot be empty");
235236
}
237+
}
238+
239+
private void invokeTrack(String trackingEventName, EvaluationContext context, TrackingEventDetails details) {
236240
openfeatureApi.getFeatureProviderStateManager(domain)
237241
.getProvider()
238242
.track(trackingEventName, mergeEvaluationContext(context), details);

0 commit comments

Comments
 (0)