Skip to content

Commit 15a0931

Browse files
committed
Rename test cases
Signed-off-by: Bence Hornák <[email protected]>
1 parent 35c2e36 commit 15a0931

File tree

1 file changed

+11
-24
lines changed
  • providers/env-var/src/commonTest/kotlin/dev/openfeature/kotlin/contrib/providers/envvar

1 file changed

+11
-24
lines changed

providers/env-var/src/commonTest/kotlin/dev/openfeature/kotlin/contrib/providers/envvar/EnvVarProviderTest.kt

Lines changed: 11 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ internal class EnvVarProviderTest {
2323
}
2424

2525
@Test
26-
fun `should evaluate bool_true value correctly`() =
26+
fun `should evaluate true as Boolean correctly`() =
2727
evaluationTest(
2828
"bool_true",
2929
"true",
@@ -44,7 +44,7 @@ internal class EnvVarProviderTest {
4444
)
4545

4646
@Test
47-
fun `should evaluate bool_false value correctly`() =
47+
fun `should evaluate false as Boolean correctly`() =
4848
evaluationTest(
4949
"bool_false",
5050
"FaLsE",
@@ -65,7 +65,7 @@ internal class EnvVarProviderTest {
6565
)
6666

6767
@Test
68-
fun `should evaluate unusual bool_false value correctly`() =
68+
fun `should evaluate unrecognized Boolean as Boolean false correctly`() =
6969
evaluationTest(
7070
"bool_false",
7171
"not-a-bool",
@@ -86,7 +86,7 @@ internal class EnvVarProviderTest {
8686
)
8787

8888
@Test
89-
fun `should evaluate string value correctly`() =
89+
fun `should evaluate String value correctly`() =
9090
evaluationTest(
9191
"string",
9292
"value",
@@ -107,7 +107,7 @@ internal class EnvVarProviderTest {
107107
)
108108

109109
@Test
110-
fun `should evaluate int value correctly`() =
110+
fun `should evaluate Int value correctly`() =
111111
evaluationTest(
112112
"INT",
113113
"42",
@@ -128,7 +128,7 @@ internal class EnvVarProviderTest {
128128
)
129129

130130
@Test
131-
fun `should evaluate double value correctly`() =
131+
fun `should evaluate Double value correctly`() =
132132
evaluationTest(
133133
"double",
134134
"42.0",
@@ -149,7 +149,7 @@ internal class EnvVarProviderTest {
149149
)
150150

151151
@Test
152-
fun `should throw FlagNotFound on missing env bool_default`() =
152+
fun `should throw FlagNotFound on missing Boolean env`() =
153153
throwingEvaluationTest<OpenFeatureError.FlagNotFoundError, Boolean>(
154154
"other",
155155
"other",
@@ -162,7 +162,7 @@ internal class EnvVarProviderTest {
162162
}
163163

164164
@Test
165-
fun `should throw FlagNotFound on missing env string_default`() =
165+
fun `should throw FlagNotFound on missing String env`() =
166166
throwingEvaluationTest<OpenFeatureError.FlagNotFoundError, String>(
167167
"other",
168168
"other",
@@ -175,7 +175,7 @@ internal class EnvVarProviderTest {
175175
}
176176

177177
@Test
178-
fun `should throw FlagNotFound on missing env int_default`() =
178+
fun `should throw FlagNotFound on missing Int env`() =
179179
throwingEvaluationTest<OpenFeatureError.FlagNotFoundError, Int>(
180180
"other",
181181
"other",
@@ -188,7 +188,7 @@ internal class EnvVarProviderTest {
188188
}
189189

190190
@Test
191-
fun `should throw FlagNotFound on missing env double_default`() =
191+
fun `should throw FlagNotFound on missing Double env`() =
192192
throwingEvaluationTest<OpenFeatureError.FlagNotFoundError, Double>(
193193
"other",
194194
"other",
@@ -200,19 +200,6 @@ internal class EnvVarProviderTest {
200200
)
201201
}
202202

203-
@Test
204-
fun `should throw FlagNotFound on missing env null_default`() =
205-
throwingEvaluationTest<OpenFeatureError.FlagNotFoundError, String>(
206-
"other",
207-
"other",
208-
) {
209-
getStringEvaluation(
210-
"null_default",
211-
"default",
212-
null,
213-
)
214-
}
215-
216203
@Test
217204
fun `should throw on unparseable values`() =
218205
throwingEvaluationTest<OpenFeatureError.ParseError, Int>(
@@ -227,7 +214,7 @@ internal class EnvVarProviderTest {
227214
}
228215

229216
@Test
230-
fun `should throw FlagNotFound on missing env double_incorrect`() =
217+
fun `should throw FlagNotFound on missing double_incorrect env`() =
231218
throwingEvaluationTest<OpenFeatureError.ParseError, Double>(
232219
"double_incorrect",
233220
"fourty-two",

0 commit comments

Comments
 (0)